[backend] Improve redis sessions list perf (#7943) #8119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8119 +/- ##
==========================================
- Coverage 66.30% 66.28% -0.02%
==========================================
Files 597 597
Lines 60949 61008 +59
Branches 6262 6268 +6
==========================================
+ Hits 40410 40442 +32
- Misses 20539 20566 +27 ☔ View full report in Codecov by Sentry. |
richard-julien
force-pushed
the
issue/7943-fix-event-loop
branch
from
feb005e
to
812b0de
Compare
SouadHadjiat
commented
Aug 23, 2024
| }; | ||
| export const getSession = async (key: string) => { | ||
| export const getSession = async (baseKeyId: string) => { | ||
| const key = `{${PLATFORM_KEY_SESSIONS}}:${baseKeyId}`; // Key of a list must be attached to the same redis slot |
There was a problem hiding this comment.
I don't understand, does it mean the session key has now PLATFORM_KEY_SESSIONS as a prefix ?
There was a problem hiding this comment.
something is wrong with this {${PLATFORM_KEY_SESSIONS}}:${baseKeyId}, when I debug this method, I find myself with a duplicate {${PLATFORM_KEY_SESSIONS}}: prefix, I'm not sure we should add it here, since the key is already named in redis with this prefix
richard-julien
force-pushed
the
issue/7943-fix-event-loop
branch
from
476147f
to
2fcd37b
Compare
SouadHadjiat
commented
Aug 28, 2024
opencti-platform/opencti-front/src/private/components/settings/SessionsList.jsx
Outdated
Show resolved
Hide resolved
SouadHadjiat
force-pushed
the
issue/7943-fix-event-loop
branch
2 times, most recently
from
df19b3f
to
ef259a7
Compare
SouadHadjiat
force-pushed
the
issue/7943-fix-event-loop
branch
from
ef259a7
to
579ac1e
Compare
richard-julien
force-pushed
the
issue/7943-fix-event-loop
branch
from
579ac1e
to
a43dce1
Compare
SamuelHassine
force-pushed
the
master
branch
from
f8359b7
to
558e6c1
Compare
SouadHadjiat
force-pushed
the
issue/7943-fix-event-loop
branch
from
4b636fd
to
0edae7c
Compare
- Prevent any event loop blocking - Adapt frontend display to show impersonate option - Limit the number of sessions displayed - Remove feature flag for telemetry - Add new API for global sessions cleanup - Remove delUserContext to only let the key die from ttl
SouadHadjiat
force-pushed
the
issue/7943-fix-event-loop
branch
from
0edae7c
to
d0e063c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues
Checklist