Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] fix remove relation ref from Grouping Knowledge graph (#6482) #6491

Merged
merged 4 commits into from
Mar 29, 2024

Conversation

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.70%. Comparing base (c08cb0e) to head (b9ebf10).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6491   +/-   ##
=======================================
  Coverage   67.70%   67.70%           
=======================================
  Files         532      532           
  Lines       64989    64989           
  Branches     5444     5445    +1     
=======================================
+ Hits        43998    43999    +1     
+ Misses      20991    20990    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@labo-flg labo-flg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with Jeremy, we shall check in all other types of containers.

@Archidoit Archidoit marked this pull request as ready for review March 28, 2024 15:22
@JeremyCloarec
Copy link
Contributor

Tested OK, great job! Love the refactoring into KnowledgeGraphQuery!
Looks like the build is only failing because of some remaining console logs in GroupingKnowledgeGraph

@Archidoit Archidoit merged commit 61d73e7 into master Mar 29, 2024
8 checks passed
@Archidoit Archidoit deleted the issue/6482 branch March 29, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
3 participants