Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] fix EE button in organization edition is not clickable (#6378) #6410

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

SarahBocognano
Copy link
Member

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.64%. Comparing base (679089e) to head (8be8bb3).
Report is 2 commits behind head on master.

❗ Current head 8be8bb3 differs from pull request most recent head a4b23e9. Consider uploading reports for the commit a4b23e9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6410      +/-   ##
==========================================
- Coverage   67.76%   67.64%   -0.13%     
==========================================
  Files         532      532              
  Lines       65065    65001      -64     
  Branches     5465     5434      -31     
==========================================
- Hits        44093    43971     -122     
- Misses      20972    21030      +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SarahBocognano SarahBocognano added the filigran team use to identify PR from the Filigran team label Mar 22, 2024
@SarahBocognano SarahBocognano self-assigned this Mar 22, 2024
@SamuelHassine SamuelHassine linked an issue Mar 22, 2024 that may be closed by this pull request
@@ -91,6 +91,7 @@ EnterpriseEditionAgreementProps
control={
<Checkbox
checked={enterpriseEditionConsent}
disabled={false}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is it for ?

@SamuelHassine
Copy link
Member

@SarahBocognano any news on this one?

@SarahBocognano SarahBocognano marked this pull request as ready for review April 3, 2024 08:22
@SamuelHassine SamuelHassine merged commit 0067e4d into master Apr 3, 2024
4 of 6 checks passed
@SamuelHassine SamuelHassine deleted the issue/6378 branch April 3, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EE button in organization edition is not clickable
3 participants