feat: Add comment & delete unused file & improve user command processing logic #435
Conversation
…ove certain logic to enhance readability
github-actions
bot
added
📒 Documentation
Walkthrough此次更改主要集中在 Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant PikiwiDB
User->>PikiwiDB: 输入命令行参数
PikiwiDB->>PikiwiDB: 解析参数
alt 使用配置文件
PikiwiDB->>PikiwiDB: 读取配置文件
end
PikiwiDB->>User: 启动并显示状态
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (54)
- README.md (1 hunks)
- README_CN.md (1 hunks)
- src/base_cmd.cc (2 hunks)
- src/base_cmd.h (1 hunks)
- src/client.cc (1 hunks)
- src/client.h (1 hunks)
- src/cmd_admin.cc (1 hunks)
- src/cmd_admin.h (3 hunks)
- src/cmd_hash.cc (1 hunks)
- src/cmd_hash.h (1 hunks)
- src/cmd_keys.cc (1 hunks)
- src/cmd_keys.h (1 hunks)
- src/cmd_kv.cc (1 hunks)
- src/cmd_kv.h (1 hunks)
- src/cmd_list.cc (1 hunks)
- src/cmd_list.h (1 hunks)
- src/cmd_raft.cc (1 hunks)
- src/cmd_raft.h (1 hunks)
- src/cmd_set.cc (1 hunks)
- src/cmd_set.h (1 hunks)
- src/cmd_table_manager.cc (1 hunks)
- src/cmd_table_manager.h (1 hunks)
- src/cmd_thread_pool.cc (1 hunks)
- src/cmd_thread_pool.h (3 hunks)
- src/cmd_thread_pool_worker.cc (1 hunks)
- src/cmd_thread_pool_worker.h (1 hunks)
- src/cmd_zset.cc (1 hunks)
- src/cmd_zset.h (1 hunks)
- src/common.cc (1 hunks)
- src/common.h (2 hunks)
- src/config.cc (1 hunks)
- src/config.h (2 hunks)
- src/config_parser.cc (1 hunks)
- src/config_parser.h (1 hunks)
- src/crc64.c (1 hunks)
- src/db.cc (1 hunks)
- src/db.h (1 hunks)
- src/helper.cc (1 hunks)
- src/helper.h (1 hunks)
- src/pikiwidb.cc (6 hunks)
- src/pikiwidb.h (1 hunks)
- src/pikiwidb_logo.h (1 hunks)
- src/proto_parser.cc (1 hunks)
- src/proto_parser.h (1 hunks)
- src/pubsub.cc (1 hunks)
- src/pubsub.h (1 hunks)
- src/replication.cc (1 hunks)
- src/replication.h (1 hunks)
- src/slow_log.cc (1 hunks)
- src/slow_log.h (1 hunks)
- src/store.cc (1 hunks)
- src/store.h (1 hunks)
- src/unbounded_buffer.cc (1 hunks)
- src/unbounded_buffer.h (1 hunks)
Files skipped from review due to trivial changes (49)
- src/base_cmd.cc
- src/base_cmd.h
- src/client.cc
- src/client.h
- src/cmd_admin.cc
- src/cmd_admin.h
- src/cmd_hash.cc
- src/cmd_hash.h
- src/cmd_keys.cc
- src/cmd_keys.h
- src/cmd_kv.cc
- src/cmd_kv.h
- src/cmd_list.cc
- src/cmd_list.h
- src/cmd_raft.cc
- src/cmd_raft.h
- src/cmd_set.cc
- src/cmd_set.h
- src/cmd_table_manager.cc
- src/cmd_table_manager.h
- src/cmd_thread_pool.cc
- src/cmd_thread_pool.h
- src/cmd_thread_pool_worker.cc
- src/cmd_thread_pool_worker.h
- src/cmd_zset.cc
- src/cmd_zset.h
- src/common.cc
- src/config.cc
- src/config_parser.cc
- src/config_parser.h
- src/crc64.c
- src/db.cc
- src/db.h
- src/helper.cc
- src/helper.h
- src/pikiwidb.h
- src/pikiwidb_logo.h
- src/proto_parser.cc
- src/proto_parser.h
- src/pubsub.cc
- src/pubsub.h
- src/replication.cc
- src/replication.h
- src/slow_log.cc
- src/slow_log.h
- src/store.cc
- src/store.h
- src/unbounded_buffer.cc
- src/unbounded_buffer.h
Additional comments not posted (23)
README_CN.md (1)
41-41: 改进命令行用法的清晰度。更新后的命令行用法通过添加
-c标志来指定配置文件，提高了命令的清晰度和用户体验。README.md (1)
41-41: 改进命令行用法的清晰度。通过添加
-c标志来指定配置文件，更新后的命令行用法提高了命令的清晰度和用户体验。src/common.h (6)
84-88: 增强AtomicString类的文档和线程安全。添加的注释清晰地描述了
AtomicString类的功能，确保了在多线程环境中的安全性。
91-99: 构造函数文档清晰。构造函数的注释详细说明了如何初始化
AtomicString实例，确保线程安全。
133-135: 赋值操作符文档清晰。赋值操作符的注释详细说明了如何设置
AtomicString的值，确保线程安全。
151-154: 转换操作符文档清晰。转换操作符的注释详细说明了如何将
AtomicString转换为std::string，确保线程安全。
167-170:empty()方法文档清晰。
empty()方法的注释详细说明了如何检查AtomicString是否为空，确保线程安全。
176-178:ToString()方法文档清晰。
ToString()方法的注释详细说明了如何将AtomicString转换为std::string，确保线程安全。src/pikiwidb.cc (3)
61-76: 改进Usage函数的清晰度。更新后的
Usage函数提供了更清晰的用户指引和示例，反映了新的命令行选项。
79-139: 增强命令行参数解析的鲁棒性。使用
getopt_long函数改进了命令行参数解析，支持长格式参数，提高了可用性和清晰度。
Line range hint
302-338: 改进main函数的结构。
main函数的结构经过优化，确保在服务器准备运行时才显示输出标志。src/config.h (12)
121-123: 增强PConfig类的文档。添加的注释清晰地描述了
PConfig类的功能和用途，提高了可读性和可维护性。
128-131: 构造函数文档清晰。构造函数的注释详细说明了如何初始化
PConfig实例。
134-137: 析构函数文档清晰。析构函数标记为默认，注释清晰说明了其功能。
140-144:LoadFromFile方法文档清晰。
LoadFromFile方法的注释详细说明了如何加载配置文件。
153-159:Get方法文档清晰。
Get方法的注释详细说明了如何检索配置参数的数据。
161-169:Set方法文档清晰。
Set方法的注释详细说明了如何设置配置参数的数据。
176-179: 公共数据成员文档清晰。公共数据成员的注释详细说明了其用途和使用方式。
338-346:AddString方法文档清晰。
AddString方法的注释详细说明了如何添加新的字符串键值对。
351-359:AddStrinWithFunc方法文档清晰。
AddStrinWithFunc方法的注释详细说明了如何添加带检查函数的字符串键值对。
365-374:AddBool方法文档清晰。
AddBool方法的注释详细说明了如何添加布尔值键值对。
380-387:AddNumber方法文档清晰。
AddNumber方法的注释详细说明了如何添加数值键值对。
393-403:AddNumberWihLimit方法文档清晰。
AddNumberWihLimit方法的注释详细说明了如何添加带限制的数值键值对。
Iam-WenYi
changed the title
…nto unstable Improve the code format
github-actions
bot
added
✏️ Feature
Iam-WenYi
changed the title
Iam-WenYi
changed the title
There was a problem hiding this comment.
Actionable comments posted: 2
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (61)
- src/base_cmd.cc (2 hunks)
- src/base_cmd.h (1 hunks)
- src/client.cc (1 hunks)
- src/client.h (1 hunks)
- src/cmd_admin.cc (1 hunks)
- src/cmd_admin.h (3 hunks)
- src/cmd_hash.cc (1 hunks)
- src/cmd_hash.h (1 hunks)
- src/cmd_keys.cc (1 hunks)
- src/cmd_keys.h (1 hunks)
- src/cmd_kv.cc (1 hunks)
- src/cmd_kv.h (1 hunks)
- src/cmd_list.cc (1 hunks)
- src/cmd_list.h (1 hunks)
- src/cmd_raft.cc (1 hunks)
- src/cmd_raft.h (1 hunks)
- src/cmd_set.cc (1 hunks)
- src/cmd_set.h (1 hunks)
- src/cmd_table_manager.cc (1 hunks)
- src/cmd_table_manager.h (1 hunks)
- src/cmd_thread_pool.cc (1 hunks)
- src/cmd_thread_pool.h (3 hunks)
- src/cmd_thread_pool_worker.cc (1 hunks)
- src/cmd_thread_pool_worker.h (1 hunks)
- src/cmd_zset.cc (1 hunks)
- src/cmd_zset.h (1 hunks)
- src/common.cc (1 hunks)
- src/common.h (2 hunks)
- src/config.cc (1 hunks)
- src/config.h (2 hunks)
- src/config_parser.cc (1 hunks)
- src/config_parser.h (1 hunks)
- src/db.cc (1 hunks)
- src/db.h (1 hunks)
- src/helper.cc (1 hunks)
- src/helper.h (1 hunks)
- src/net/base_event.h (1 hunks)
- src/net/base_socket.h (1 hunks)
- src/net/callback_function.h (1 hunks)
- src/net/client_socket.h (1 hunks)
- src/net/epoll_event.h (1 hunks)
- src/net/event_server.h (2 hunks)
- src/net/io_thread.h (1 hunks)
- src/net/kqueue_event.h (1 hunks)
- src/net/thread_manager.h (3 hunks)
- src/pikiwidb.cc (6 hunks)
- src/pikiwidb.h (1 hunks)
- src/pikiwidb_logo.h (1 hunks)
- src/proto_parser.cc (1 hunks)
- src/proto_parser.h (1 hunks)
- src/pubsub.cc (1 hunks)
- src/pubsub.h (1 hunks)
- src/replication.cc (1 hunks)
- src/replication.h (1 hunks)
- src/slow_log.cc (1 hunks)
- src/slow_log.h (1 hunks)
- src/storage/src/base_data_value_format.h (1 hunks)
- src/store.cc (1 hunks)
- src/store.h (1 hunks)
- src/unbounded_buffer.cc (1 hunks)
- src/unbounded_buffer.h (1 hunks)
Files skipped from review due to trivial changes (42)
- src/base_cmd.cc
- src/base_cmd.h
- src/client.cc
- src/client.h
- src/cmd_admin.h
- src/cmd_hash.cc
- src/cmd_keys.cc
- src/cmd_keys.h
- src/cmd_kv.cc
- src/cmd_kv.h
- src/cmd_list.cc
- src/cmd_list.h
- src/cmd_raft.h
- src/cmd_set.cc
- src/cmd_table_manager.cc
- src/cmd_table_manager.h
- src/cmd_thread_pool.cc
- src/cmd_thread_pool.h
- src/cmd_thread_pool_worker.cc
- src/cmd_thread_pool_worker.h
- src/common.cc
- src/config.cc
- src/config_parser.cc
- src/db.h
- src/helper.cc
- src/net/base_event.h
- src/net/base_socket.h
- src/net/callback_function.h
- src/net/client_socket.h
- src/net/epoll_event.h
- src/net/event_server.h
- src/net/io_thread.h
- src/net/kqueue_event.h
- src/net/thread_manager.h
- src/pikiwidb_logo.h
- src/proto_parser.cc
- src/replication.cc
- src/slow_log.h
- src/storage/src/base_data_value_format.h
- src/store.cc
- src/store.h
- src/unbounded_buffer.h
Files skipped from review as they are similar to previous changes (18)
- src/cmd_admin.cc
- src/cmd_hash.h
- src/cmd_raft.cc
- src/cmd_set.h
- src/cmd_zset.cc
- src/cmd_zset.h
- src/common.h
- src/config_parser.h
- src/db.cc
- src/helper.h
- src/pikiwidb.cc
- src/pikiwidb.h
- src/proto_parser.h
- src/pubsub.cc
- src/pubsub.h
- src/replication.h
- src/slow_log.cc
- src/unbounded_buffer.cc
Additional comments not posted (10)
src/config.h (10)
2-8: 文件头部注释已添加。这些注释清晰地描述了文件的用途和版权信息，增强了文件的文档性。
135-137: 析构函数标记为默认。将析构函数显式标记为默认是合适的，因为这表明需要默认行为。
154-159:Get方法签名更新。在方法签名中添加参数名称提高了可读性和对方法目的的理解。
162-169:Set方法签名更新。添加
init_stage参数允许在初始化期间对配置更改进行更细致的控制。
178-180: 公共数据成员注释已添加。这些注释增强了代码的理解性和可维护性。
340-347: 内联函数用于添加配置参数。这些函数及其附带的注释提高了模块化和清晰度。
122-123:PConfig类文档已添加。为
PConfig类及其方法添加的详细文档显著提高了代码的清晰度和可维护性。
242-247: 新增原子变量已添加。新增的原子变量如
daemonize、pid_file和max_client_response_size增强了服务器的可配置性，并且文档完善。
141-144:LoadFromFile方法文档已添加。文档清晰地说明了方法的目的和使用方式。
148-150:ConfigFileName方法文档已添加。文档增强了对方法功能的理解。
src/config.h
Outdated
| * AddNumberWihLimit (const std::string& key, bool rewritable, std::atomic<T>* value_ptr, T min, T max) | ||
| * Introduce a new string key-value pair into the | ||
| * configuration data layer, with a check function. | ||
| * key is a string and value_ptr is a set of numbers. | ||
| * rewritable represents whether to overwrite existing settings | ||
| * when a key-value pair is duplicated. | ||
| * Please note that this function does not have a checkfunc function, | ||
| * as we have replaced it with the upper and lower limits | ||
| * of the numbers passed in. | ||
| */ |
There was a problem hiding this comment.
修正函数名中的拼写错误。
函数名 "AddNumberWihLimit" 似乎有拼写错误，可能应为 "AddNumberWithLimit" 以保持一致性和清晰度。
使用以下 diff 修正拼写错误：
- template <typename T> inline void AddNumberWihLimit(const std::string& key, bool rewritable, std::atomic<T>* value_ptr, T min, T max) {
+ template <typename T> inline void AddNumberWithLimit(const std::string& key, bool rewritable, std::atomic<T>* value_ptr, T min, T max) {Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| * AddNumberWihLimit (const std::string& key, bool rewritable, std::atomic<T>* value_ptr, T min, T max) | |
| * Introduce a new string key-value pair into the | |
| * configuration data layer, with a check function. | |
| * key is a string and value_ptr is a set of numbers. | |
| * rewritable represents whether to overwrite existing settings | |
| * when a key-value pair is duplicated. | |
| * Please note that this function does not have a checkfunc function, | |
| * as we have replaced it with the upper and lower limits | |
| * of the numbers passed in. | |
| */ | |
| template <typename T> inline void AddNumberWithLimit(const std::string& key, bool rewritable, std::atomic<T>* value_ptr, T min, T max) { |
src/config.h
Outdated
| * AddStrinWithFunc (const std::string& key, const CheckFunc& checkfunc, bool rewritable, | ||
| std::vector<AtomicString*> values_ptr_vector) | ||
| * Introduce a new string key-value pair into the | ||
| * configuration data layer, with a check function. | ||
| * key, value, rewritable is the same as AddString. | ||
| * The checkfunc is coded by the user, validate the string as needed, | ||
| * and the return value should refer to rocksdb::Status. | ||
| */ | ||
| inline void AddStrinWithFunc(const std::string& key, const CheckFunc& checkfunc, bool rewritable, | ||
| std::vector<AtomicString*> values_ptr_vector) { | ||
| config_map_.emplace(key, std::make_unique<StringValue>(key, checkfunc, rewritable, values_ptr_vector)); | ||
| } | ||
|
|
There was a problem hiding this comment.
修正函数名中的拼写错误。
函数名 "AddStrinWithFunc" 似乎有拼写错误，可能应为 "AddStringWithFunc" 以保持一致性和清晰度。
使用以下 diff 修正拼写错误：
- inline void AddStrinWithFunc(const std::string& key, const CheckFunc& checkfunc, bool rewritable,
+ inline void AddStringWithFunc(const std::string& key, const CheckFunc& checkfunc, bool rewritable,Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| * AddStrinWithFunc (const std::string& key, const CheckFunc& checkfunc, bool rewritable, | |
| std::vector<AtomicString*> values_ptr_vector) | |
| * Introduce a new string key-value pair into the | |
| * configuration data layer, with a check function. | |
| * key, value, rewritable is the same as AddString. | |
| * The checkfunc is coded by the user, validate the string as needed, | |
| * and the return value should refer to rocksdb::Status. | |
| */ | |
| inline void AddStrinWithFunc(const std::string& key, const CheckFunc& checkfunc, bool rewritable, | |
| std::vector<AtomicString*> values_ptr_vector) { | |
| config_map_.emplace(key, std::make_unique<StringValue>(key, checkfunc, rewritable, values_ptr_vector)); | |
| } | |
| inline void AddStringWithFunc(const std::string& key, const CheckFunc& checkfunc, bool rewritable, | |
| std::vector<AtomicString*> values_ptr_vector) { | |
| config_map_.emplace(key, std::make_unique<StringValue>(key, checkfunc, rewritable, values_ptr_vector)); | |
| } |
Iam-WenYi
changed the title
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
src/config.cc (1)
111-111: 函数名拼写修正不一致。在以下文件中仍然存在旧的函数名
AddNumberWihLimit和AddStrinWithFunc，请进行修正以确保一致性：
src/config.cc:AddNumberWihLimit<size_t>("databases", false, &databases, 1, DBNUMBER_MAX);src/config.h:* checkfunc is the same as AddStrinWithFunc.请在代码库中进行相应的更改以保持一致性。
Analysis chain
函数名拼写修正已完成。
函数名已从
AddNumberWihLimit和AddStrinWithFunc修正为AddNumberWithLimit和AddStringWithFunc。请确保在整个代码库中保持一致。运行以下脚本以验证整个代码库中的一致性：
Also applies to: 115-115, 120-126
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify corrected function names are consistent across the codebase. # Test: Search for the old function names. Expect: No occurrences. rg --type cc --type h $'AddNumberWihLimit|AddStrinWithFunc'Length of output: 87
Script:
#!/bin/bash # Description: Verify corrected function names are consistent across the codebase. # Test: Search for the old function names. Expect: No occurrences. rg --type cpp --type h $'AddNumberWihLimit|AddStrinWithFunc'Length of output: 214
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- src/config.cc (2 hunks)
- src/config.h (2 hunks)
Additional comments not posted (4)
src/config.cc (1)
2-9: 文件头部注释更新已完成。文件头部注释已更新，准确反映了文件的用途和版权信息。
src/config.h (3)
121-123: 文档更新已完成。
PConfig类及其方法的文档已更新，显著提高了代码的清晰度和可维护性。请确保所有文档准确无误，并在必要时进行细化。Also applies to: 126-131, 134-137, 140-144, 147-150, 153-158, 161-168, 172-175, 178-180, 183-184, 187-190, 195-199, 201-208, 212-215, 219-226, 231-233, 235-238, 242-244, 245-247, 249-252, 257-261, 264-266, 267-269, 271-274, 278-280, 283-285, 287-289, 293-295, 296-296, 299-303, 308-310, 311-313, 314-316, 317-319, 326-328, 329-330, 337-338, 339-347, 352-360, 366-375, 381-388, 394-404, 411-413, 414-416, 417-417
361-362: 函数名拼写修正已完成。函数名已从
AddNumberWihLimit和AddStrinWithFunc修正为AddNumberWithLimit和AddStringWithFunc。请确保在整个代码库中保持一致。Also applies to: 406-406
256-263: 新方法和原子变量已添加。新的方法和原子变量已正确添加并记录，增强了配置功能。请确保它们与预期功能一致。
Also applies to: 270-276, 286-292
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (6)
- README.md (1 hunks)
- README_CN.md (1 hunks)
- src/base_cmd.cc (2 hunks)
- src/cmd_thread_pool.h (2 hunks)
- src/config.h (2 hunks)
- src/pikiwidb.cc (7 hunks)
Files skipped from review due to trivial changes (2)
- src/base_cmd.cc
- src/cmd_thread_pool.h
Files skipped from review as they are similar to previous changes (4)
- README.md
- README_CN.md
- src/config.h
- src/pikiwidb.cc
There was a problem hiding this comment.
Actionable comments posted: 2
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/pikiwidb.cc (7 hunks)
Additional comments not posted (3)
src/pikiwidb.cc (3)
60-75: 更新了 Usage 函数，增加了新的命令行选项。此更改有助于提高用户体验和标准化选项处理。
79-135: 优化了命令行参数解析逻辑，使用getopt_long。此更改有助于更好地管理命令行选项，包括对长格式参数的支持。
Line range hint
298-334: 主函数更新，使用新的参数名称argc和argv，并改进了初始化序列。此更改提高了代码的清晰度，并符合常见的 C++ 惯例。
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range, codebase verification and nitpick comments (1)
src/pikiwidb.cc (1)
Line range hint
299-336: 主函数更新，集成了新的参数解析逻辑。更新后的主函数使用新的命令行参数解析逻辑，并确保服务器正确启动。
修复 PikiwiDB 标志输出的一致性问题。
确保输出的端口号与实际使用的端口号一致。
建议在输出标志之前验证端口号的正确性。
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/pikiwidb.cc (7 hunks)
Additional comments not posted (3)
src/pikiwidb.cc (3)
60-75: 更新了命令行选项的帮助信息。更新后的帮助信息更加清晰，易于用户理解，反映了新的命令行选项。
Line range hint
141-213: 初始化服务器组件和配置。该函数负责初始化服务器的各种组件和配置，确保服务器能够正确运行。
Line range hint
214-225: 处理服务器的主执行循环。该函数负责启动服务器并处理其生命周期。
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/pikiwidb.cc (7 hunks)
Additional comments not posted (3)
src/pikiwidb.cc (3)
60-75: 更新帮助信息以提高用户友好性。更新了
Usage函数，以更清晰地向用户展示命令行选项。这有助于用户更好地理解如何使用 PikiwiDB。
79-143: 优化命令行参数解析逻辑。使用
getopt_long替代简单循环，增强了参数处理的灵活性和清晰度。新的实现方式支持长格式参数，提升了用户体验。
Line range hint
306-342: 改进主函数结构和错误处理。主函数现在更加结构化，错误处理也有所改进。特别是，程序现在会在解析参数失败时输出使用信息，并且在配置文件加载失败时提供错误信息。
| @@ -104,22 +106,22 @@ Status NumberValue<T>::SetValue(const std::string& value) { | |||
| PConfig::PConfig() { | |||
| AddBool("daemonize", &CheckYesNo, false, &daemonize); | |||
| AddString("ip", false, {&ip}); | |||
| AddNumberWihLimit<uint16_t>("port", false, &port, PORT_LIMIT_MIN, PORT_LIMIT_MAX); | |||
| AddNumberWithLimit<uint16_t>("port", false, &port, PORT_LIMIT_MIN, PORT_LIMIT_MAX); | |||
There was a problem hiding this comment.
当时写的太不小心了，看的也太仔细了，点赞
（PikiwiDB 中绝大部分的源代码，补充了其作用的说明注释）
（PikiwiDB 帮助信息美化）
（处理逻辑优化，现在不再需要通过猜测 argc, argv 的位置就可以处理参数）
（解决自定义参数以后，PikiwiDB Logo 输出时的 port 和实际的 port 不一致的问题）
Summary by CodeRabbit
新功能
pikiwidb的用法，支持更清晰的命令参数解析，增加了长命令参数。--version、--help、--port、--loglevel和--slaveof，提高了用户体验。文档
样式