R sharp r6 #1417
R sharp r6 #1417
Conversation
- Run docs
Docs
@Felixmil what is the workflow for this? Right now, the version in DESCRIPTION is 12.0.0.9003. Do I manually change it to 12.1.0? |
Not really manually, we use the Usually we create a separate PR to achieve this but nothing's wrong to do it directly in this one. I will take care of it. |
…logy/OSPSuite-R into r-sharp-r6 # Conflicts: # DESCRIPTION
| @@ -6,113 +6,47 @@ | |||
| #' sim <- loadSimulation(system.file("extdata", "Aciclovir.pkml", package = "ospsuite")) | |||
| #' | |||
| #' # looking at a reference to `.NET` simulation object | |||
| #' sim$ref | |||
| #' sim$pointer | |||
There was a problem hiding this comment.
@PavelBal Why did we rename this to pointer?
Where is the NetObject class coming from?
There was a problem hiding this comment.
NetObject is implemented in {rSharp}: https://www.open-systems-pharmacology.org/rSharp/articles/user-guide.html#object-pointers-and-the-netobject-class
In rClr, ref was an S3 object. Now, it is the external pointer externalptr that is held by NetObject.
|
Woop-wooop, all tests and checks are passing under Windows AND Linux! @Yuri05 @msevestre can we merge and create a pre-release? :) |
cool! just merged! |
Fixes #1413
Fixes #1395
Fixes #1422
Fixes #1432
Fixes #1449