-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error device tests #707
Open
Ostrokrzew
wants to merge
3
commits into
Open-CAS:master
Choose a base branch
from
Ostrokrzew:read_hit_tests
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Error device tests #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arutk
reviewed
Feb 26, 2021
test/functional/tests/fault_injection/test_error_device_as_cache.py
Outdated
Show resolved
Hide resolved
Add missing `f` to **strings** that should be **f-strings**. Signed-off-by: Slawomir Jankowski <slawomir.jankowski@intel.com>
while error device is used as cache device Signed-off-by: Slawomir Jankowski <slawomir.jankowski@intel.com>
Signed-off-by: Slawomir Jankowski <slawomir.jankowski@intel.com>
Ostrokrzew
force-pushed
the
read_hit_tests
branch
from
March 4, 2021 12:04
e0c97c6
to
17ccb0f
Compare
retest this please |
Can one of the admins verify this patch? |
Deixx
reviewed
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commit minor fixes in tests can be dropped
otherwise looks ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs https://github.com/Open-CAS/test-framework/pull/240