test_add:test_fault_injection_core_in_raid #1387
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmichal10
reviewed
Oct 19, 2022
test/functional/tests/fault_injection/test_fault_injection_core_in_raid.py
Outdated
Show resolved
Hide resolved
test/functional/tests/fault_injection/test_fault_injection_core_in_raid.py
Outdated
Show resolved
Hide resolved
test/functional/tests/fault_injection/test_fault_injection_core_in_raid.py
Outdated
Show resolved
Hide resolved
Kgierszx
force-pushed
the
test_fault_injection
branch
from
157ce76
to
7bf49e3
Compare
test/functional/tests/fault_injection/test_fault_injection_core_in_raid.py
Outdated
Show resolved
Hide resolved
Kgierszx
force-pushed
the
test_fault_injection
branch
4 times, most recently
from
864d4ce
to
d76f81a
Compare
mmichal10
reviewed
Oct 21, 2022
Kgierszx
force-pushed
the
test_fault_injection
branch
from
d76f81a
to
edce577
Compare
karolinavelkaja
previously approved these changes
Oct 27, 2022
mmichal10
reviewed
Oct 31, 2022
Comment on lines
259
to
274
| def check_stdout_msg(output: Output, expected_messages, negate=False): | ||
| return __check_string_msg(output.stdout, expected_messages, negate) | ||
|
|
||
|
|
||
| def __check_string_msg(text: str, expected_messages, negate=False): | ||
| def check_string_msg_all(text: str, expected_messages): | ||
| msg_ok = True | ||
| for msg in expected_messages: | ||
| matches = re.search(msg, text) | ||
| if not matches and not negate: | ||
| if not matches: | ||
| TestRun.LOGGER.error(f"Message is incorrect, expected: {msg}\n actual: {text}.") | ||
| msg_ok = False | ||
| elif matches and negate: | ||
| TestRun.LOGGER.error(f"Message is incorrect, expected to not find: {msg}\n " | ||
| f"actual: {text}.") | ||
| msg_ok = False | ||
| return msg_ok | ||
|
|
||
|
|
||
| def check_string_msg_any(text: str, expected_messages): | ||
| msg_ok = False | ||
| for msg in expected_messages: | ||
| matches = re.search(msg, text) | ||
| if matches: | ||
| msg_ok = True | ||
| break | ||
| if not msg_ok: | ||
| TestRun.LOGGER.error(f"Message is incorrect: {text}.") |
There was a problem hiding this comment.
check_string_msg_all() and check_string_msg_any() are perfect opportunities to use python's all() and any(). Consider the following:
def check_string_msg_all(text: str, expected_messages):
if all([re.match(m, text) for m in expected_messages]):
return True
TestRun.LOGGER.error(f"Message is incorrect, expected: {msg}\n Got: {text}.")
return False
and
def check_string_msg_any(text: str, expected_messages):
if any([re.match(m, text) for m in expected_messages]):
return True
TestRun.LOGGER.error(f"Message is incorrect, expected at least one of: {msg}\n Got: {text}.")
return False
Comment on lines
14
to
15
| partition_not_suitable_for_array, | ||
| device_or_resource_busy, |
There was a problem hiding this comment.
I couldn't find partition_not_suitable_for_array and device_or_resource_busy in cli_messages.py, so I guess you've forgotten to add them to the index. Additionally, as the are mdadm's error messages not casadm's, I suggest adding some kind of prefix to make it clear.
Kgierszx
force-pushed
the
test_fault_injection
branch
2 times, most recently
from
c470d87
to
12733eb
Compare
Signed-off-by: Kamil Gierszewski <kamilx.gierszewski@intel.com>
Kgierszx
force-pushed
the
test_fault_injection
branch
from
be4e5f1
to
2f0a684
Compare
Signed-off-by: Kamil Gierszewski <kamilx.gierszewski@intel.com>
karolinavelkaja
approved these changes
Dec 7, 2022
mmichal10
approved these changes
Dec 19, 2022
Deixx
reviewed
Aug 30, 2024
Comment on lines
+255
to
+261
| mdadm_partition_not_suitable_for_array = [ | ||
| r"\S+ is not suitable for this array" | ||
| ] | ||
|
|
||
| mdadm_device_or_resource_busy = [ | ||
| r"mdadm: cannot open \S+: Device or resource busy" | ||
| ] |
There was a problem hiding this comment.
should be probably moved to test-framework/test_tools/mdadm.py or just to test/functional/tests/fault_injection/test_fault_injection_core_in_raid.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kamil Gierszewski kamilx.gierszewski@intel.com