-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Huijie fix add lost hours editing deleting #2710
base: development
Are you sure you want to change the base?
Huijie fix add lost hours editing deleting #2710
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR 2710
@metaphor987
Tested the Changes of Code and Working As Described.
Features of Adding, Updating and Deleting are working Fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can confirm that code works as intended. But TinyMCE is throwing errors and blocking the whole page since our app doesn't bundle tinymce.min.js
anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have approved this PR and addition, deletion and update of files are working fine, below is the Video for reference:
PR1115_.screenshot.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Related PRS (if any):
This frontend PR is related to the backend PR 1115(OneCommunityGlobal/HGNRest#1115).
Please check the backend PR for more details.
Main changes explained:
Fix the error that owner user cannot add lost time for teams.
How to test:
npm install
andnpm run start:local
to run this PR locally