Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Huijie fix add lost hours editing deleting #2710

Open
wants to merge 5 commits into
base: development
Choose a base branch
from

Conversation

metaphor987
Copy link
Contributor

Description

1

Related PRS (if any):

This frontend PR is related to the backend PR 1115(OneCommunityGlobal/HGNRest#1115).
Please check the backend PR for more details.

Main changes explained:

Fix the error that owner user cannot add lost time for teams.

How to test:

  1. check into current branch
  2. do npm install and npm run start:local to run this PR locally
  3. Clear site data/cache
  4. log as admin or owner user
  5. go to Reports -> Reports -> Add Lost Time, or Show Person Lost Time, verify that the errors in adding, updating and deleting lost hours do not occur. Please check the backend PR for more details. Thank you!

Copy link

netlify bot commented Sep 22, 2024

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 97f6080
🔍 Latest deploy log https://app.netlify.com/sites/highestgoodnetwork-dev/deploys/66efb898eb479900089cd760
😎 Deploy Preview https://deploy-preview-2710--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@Dk-21 Dk-21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR 2710

@metaphor987
Tested the Changes of Code and Working As Described.
Features of Adding, Updating and Deleting are working Fine.

PR 2710(3) PR 2710(2) PR 2710(1)

Copy link

@ishangoel17 ishangoel17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the PR and the changes are working as expected. Features of Adding, Updating and Deleting are working as expected without any errors. Below are the screenshots for reference:
Capture2710_1
Capture2710_2
Capture2710_3

@pallavithorat
Copy link

I have verified the PR, and the changes are functioning as expected. The features for adding, updating, and deleting are all working smoothly without any errors. Please find the reference screenshots below.
PR#2710
Screenshot 2024-10-11 at 1 42 31 PM
Screenshot 2024-10-11 at 1 42 53 PM

@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Oct 14, 2024
Copy link

@Ankuriboh Ankuriboh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that code works as intended. But TinyMCE is throwing errors and blocking the whole page since our app doesn't bundle tinymce.min.js anymore.

@zhiminV
Copy link

zhiminV commented Oct 19, 2024

I have checked many time that I am inn this branch, but when I login as Admin, I did not see button Add Lost Time. Not sure the problem.
IMG_0872
Screenshot 2024-10-18 at 9 42 04 PM

Copy link

@javid679 javid679 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have approved this PR and addition, deletion and update of files are working fine, below is the Video for reference:

PR1115_.screenshot.mp4

@zhiminV
Copy link

zhiminV commented Oct 20, 2024

I have checked many time that I am inn this branch, but when I login as Admin, I did not see button Add Lost Time. Not sure the problem. IMG_0872 Screenshot 2024-10-18 at 9 42 04 PM

I found the reason in backend that the admin account can not add lost hours, that's why I do not see the button
IMG_0879

@sheetalmangate
Copy link

I could not test this PR locally. while adding new time entry it is showing me pop up with message blow

"An error occurred while attempting to submit your time entry. Error code: 500"

PR_2710_error

Copy link

@hqzhu0913 hqzhu0913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The editing and delete function work as expected but there is no add function like in other's comment.
Screenshot 2024-10-22 at 12 07 39 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants