Yufei - Add a mouseover text edit button near 'Total Time' #454

yufeiStella · 2023-07-22T00:50:41Z

Description

Related PRS (if any):

To test this backend PR you need to checkout the #1030 frontend PR.

Main changes explained:

Create new modal mouseoverText.js
Create new controller mouseoverTextController.js
Create new routes mouseoverTextRoute.js
Update startup/routes to add mouseoverText api

How to test:

check into current branch
do npm install and ... to run this PR locally
log in as an owner user and verify that the mouseover text appears when you move your mouse over both 'Total Time' and the numbers on the Leaderboard. Some numbers are blue (indicating intangible hours logged), and some numbers are black. Mouseover text will appear on both types of numbers.
Only the owner can see the edit button next to 'Total Time'. Click on it and enter the new text to update the mouseover text. Please note that it may take some time to respond, as shown in my screen recording.
Wait a few seconds for a green pop-up box to appear, showing the message "Mouseover Text updated!" Then you will see the newly updated mouseover text when you move your mouse over both 'Total Time' and the numbers. If you don't immediately see the changes, just wait a few more seconds, as it may take some time for the updates to respond.
Hard refresh the page to see the change is globally. The same thing is if you don't immediately see the changes, just wait a few more seconds, as it may take some time for the updates to respond.
log in as any other role to verify the mouseoverText updates globally and they do not see the edit button.

Screenshots or videos of changes:

Log in as an owner:

Screen.Recording.2023-08-03.at.21.10.09.mov

Log in as any other user except owner:

Screen.Recording.2023-08-03.at.21.15.51.mov

Note:

Sometimes, you may need to wait for the page to respond and display the mouseover text. I encountered a similar situation as shown in my screenshot recording. When you move your mouse to another place where there should be mouseover text, you may experience the same situation. Just be patient and wait.

This reverts commit 9b79d61. I don't need such changes not relating to my part#

Merge changes from development

n0vay · 2023-07-22T06:38:51Z

How do I create a owner account?

AuroraLovesWhales

Hi @yufeiStella. I have left my comment in the related frontend PR. The functionality is working as intended. Great job!

shiva2096

Hi @yufeiStella

Reviewed this PR with frontend PR 1030, working as expected .

AnishPandita · 2023-07-25T00:34:53Z

Hi @yufeiStella I can confirm it works as intended.

DavidC0126

Hi @yufeiStella,

Reviewed this PR with frontend PR#1030, working as expected.

sxiong5

Hey, I left a comment in HighestGoodNetworkApp#1030. The PR worked as expected.

veronicacheng2

Hi @yufeiStella, I have tested together with the Frontend, and they are working as intended

When logged in as Owner, there will be a text edit button:

Clicking the edit text button:

Hovering to total time:

No edit text button when logged in as volunteer:

Shreyj14 · 2023-07-26T22:13:16Z

Hi @yufeiStella

Reviewed this PR with frontend PR 1030, working as expected .

iTvX · 2023-07-27T20:42:58Z

Tested with the front end, I have review on the front end.

I have checked your PR. The owner can change the text, and it looks good. But when I switch accounts (not the owner's account), I cannot see the text. It seems like it's not global.

256637192-cd5d1198-0e63-4f84-a35d-92400f833841.mp4

mounica-dingari-by · 2023-07-28T04:46:52Z

Hi @yufeiStella , this feature works as expected, but the page is little slow . I'm not sure, if it's because this branch or not. I'm including the screenshots below.

iTvX · 2023-07-28T16:41:11Z

src/controllers/mouseoverTextController.js

+
+ return MouseoverText.findById(id, (error, mouseoverText) => {
+ if (error || mouseoverText === null) {
+ res.status(400).send('No mouseoverText found');


400 means bad request, but in this case the error could be database error. I suggest use error 500.

Thank you! I use error 500 now.

yurisokolovicz

Dear @yufeiStella,

The code looks good overall. I think making minor corrections in error handling could help in further debugging. Excellent work!

yurisokolovicz · 2023-08-01T14:06:13Z

src/controllers/mouseoverTextController.js

+
+ return MouseoverText.findById(id, (error, mouseoverText) => {
+ if (error || mouseoverText === null) {
+ res.status(400).send('No mouseoverText found');


For improving error handling, I think the error 404 code could be used, along with a more intuitive error message that could aid in debugging.

Example:

res.status(404).send('MouseoverText not found with the given ID' );

Updated! @yurisokolovicz, could you please re-review the PR and approve it if you agree with it? Thank you

yufeiStella · 2023-08-02T05:29:12Z

Tested with the front end, I have review on the front end.

I have checked your PR. The owner can change the text, and it looks good. But when I switch accounts (not the owner's account), I cannot see the text. It seems like it's not global.

256637192-cd5d1198-0e63-4f84-a35d-92400f833841.mp4

Hi @iTvX! It's all about slow loading but the change is global. For me, usually I just reload it again since it's too slow. You can also find that we are talking the problem in slack(code channel).

This reverts commit 3e630a5. revert unnecessary commit

Merge with development

yurisokolovicz

Perfect!

beblicarl · 2023-08-02T18:31:50Z

Tested, everything works as expected and the code is great!

yufeiStella added 4 commits July 20, 2023 06:31

add mouseoverText modal controller routes

79fb3bf

changes in the backend

9b79d61

Revert "changes in the backend"

1a4b655

This reverts commit 9b79d61. I don't need such changes not relating to my part#

Merge branch 'development' into yufei_mouseover_text_controller

04cc24a

Merge changes from development

yufeiStella mentioned this pull request Jul 22, 2023

Yufei - make intangible time numbers having a mouseover explanation editable by the owner OneCommunityGlobal/HighestGoodNetworkApp#1030

Merged

AuroraLovesWhales approved these changes Jul 23, 2023

View reviewed changes

shiva2096 approved these changes Jul 23, 2023

View reviewed changes

DavidC0126 approved these changes Jul 25, 2023

View reviewed changes

sxiong5 approved these changes Jul 25, 2023

View reviewed changes

veronicacheng2 approved these changes Jul 26, 2023

View reviewed changes

Shreyj14 approved these changes Jul 26, 2023

View reviewed changes

iTvX reviewed Jul 28, 2023

View reviewed changes

yurisokolovicz suggested changes Aug 1, 2023

View reviewed changes

update error code type

28e9ca0

yufeiStella requested a review from yurisokolovicz August 2, 2023 05:55

yufeiStella added 3 commits August 2, 2023 01:55

Committing local changes before merging with development

3e630a5

Revert "Committing local changes before merging with development"

66f3182

This reverts commit 3e630a5. revert unnecessary commit

Merge branch 'development' into yufei_mouseover_text_controller

0aa45f3

Merge with development

yurisokolovicz approved these changes Aug 2, 2023

View reviewed changes

beblicarl self-requested a review August 2, 2023 18:32

beblicarl approved these changes Aug 2, 2023

View reviewed changes

one-community added the Moved to Final Review label Aug 2, 2023

one-community merged commit 63321d7 into development Aug 4, 2023
3 checks passed

one-community mentioned this pull request Aug 7, 2023

Backend Release to Main [0.81] #469

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Yufei - Add a mouseover text edit button near 'Total Time' #454

Yufei - Add a mouseover text edit button near 'Total Time' #454

yufeiStella commented Jul 22, 2023 •

edited

Loading

n0vay commented Jul 22, 2023

AuroraLovesWhales left a comment

shiva2096 left a comment

AnishPandita commented Jul 25, 2023

DavidC0126 left a comment

sxiong5 left a comment

veronicacheng2 left a comment

Shreyj14 commented Jul 26, 2023

iTvX commented Jul 27, 2023 •

edited

Loading

mounica-dingari-by commented Jul 28, 2023 •

edited

Loading

iTvX Jul 28, 2023

yufeiStella Aug 2, 2023

yurisokolovicz left a comment

yurisokolovicz Aug 1, 2023

yufeiStella Aug 2, 2023

yufeiStella commented Aug 2, 2023 •

edited

Loading

yurisokolovicz left a comment

beblicarl commented Aug 2, 2023

Yufei - Add a mouseover text edit button near 'Total Time' #454

Yufei - Add a mouseover text edit button near 'Total Time' #454

Conversation

yufeiStella commented Jul 22, 2023 • edited Loading

Description

Related PRS (if any):

Main changes explained:

How to test:

Screenshots or videos of changes:

Note:

n0vay commented Jul 22, 2023

AuroraLovesWhales left a comment

Choose a reason for hiding this comment

shiva2096 left a comment

Choose a reason for hiding this comment

AnishPandita commented Jul 25, 2023

DavidC0126 left a comment

Choose a reason for hiding this comment

sxiong5 left a comment

Choose a reason for hiding this comment

veronicacheng2 left a comment

Choose a reason for hiding this comment

Shreyj14 commented Jul 26, 2023

iTvX commented Jul 27, 2023 • edited Loading

mounica-dingari-by commented Jul 28, 2023 • edited Loading

iTvX Jul 28, 2023

Choose a reason for hiding this comment

yufeiStella Aug 2, 2023

Choose a reason for hiding this comment

yurisokolovicz left a comment

Choose a reason for hiding this comment

yurisokolovicz Aug 1, 2023

Choose a reason for hiding this comment

yufeiStella Aug 2, 2023

Choose a reason for hiding this comment

yufeiStella commented Aug 2, 2023 • edited Loading

yurisokolovicz left a comment

Choose a reason for hiding this comment

beblicarl commented Aug 2, 2023

yufeiStella commented Jul 22, 2023 •

edited

Loading

iTvX commented Jul 27, 2023 •

edited

Loading

mounica-dingari-by commented Jul 28, 2023 •

edited

Loading

yufeiStella commented Aug 2, 2023 •

edited

Loading