Yongjian - Update message for inactive user account after login

[ypan710]

Description

Main changes explained:

Display the message "Sorry, this account is no longer active. If you feel this is in error, please contact your Manager and/or Administrator." if the user exists in the database but his or her profile is not active.

How to test:

1. check into current branch from the backend
2. do npm run build and npm start from the backend
3. check into development branch from the frontend
4. do npm run start:local to run the frontend
5. log in as admin user
6. go to dashboard→ User Management -> search for a non-admin role of under your account -> change "Active" status to "Inactive" by clicking on the green dot
7. log out of your admin account
8. attempt to login with the non-admin role with status already set to "Inactive" from step 6
9. verify that the message "Sorry, this account is no longer active. If you feel this is in error, please contact your Manager and/or Administrator." is displayed after clicking on submit button after entering credentials

Screenshots

[HectorAgudelo]

The changes to the code perform as expected. nice!

[AaronPersaud]

Everything looks good!

Changed user to inactive

Inactive message

• user gets inactive user message instead of invalid email/password

I have approved the PR.

[luisarevalo21]

Hello ypan710,
I have reviewed your code and works as intended great job!

However, I did receive one error when attempting to login as both an admin and a volunteer. See screenshot.

Error Received

• I get "Cannot set headers after are sent to the client" on the the backend server.

[siddharthmohite]

This works as expected. Displays the message if user is inactive.

[igorrochadasilva]

Hello @ypan710 !
Great work = D

The Pr's works as intended.

Inactive user on dashboard user manager

If I try to access with the user, I receive the message.

The code looks well 🚀

[beblicarl]

This functionality works as intended. However, we have some errors in the backend console log.

SCREENSHOT

ERROR MESSAGE

[one-community]

This functionality works as intended. However, we have some errors in the backend console log.

Please request a change rather than approve something like this.

[tdkent]

Local testing of this branch confirms

• the updated error message is displayed to a user attempting to login with an "inactive" account.
• the error message is displayed regardless of the value entered in the Password input (unless no value is entered, in which case a validation error is displayed).
• an error with code 403 is returned from the backend and logged to the frontend console.

Errors
The following error is logged to the backend console each time a login request for an inactive user is sent: Cannot set headers after they are sent to the client

• the error does not occur when invoking the "Invalid password" error for an active user in the same if/else block.

Testing Video:

438-be-demo.mov

[tdkent]

Confirmed that the Cannot set headers after they are sent to the client error has been fixed. Nice job!

[bienzguoa]

It works perfect! The code is clear and helps understand.

[iTvX]

I have reviewed your code and test it, it looks good.

253656739-46e301de-a751-4f8c-bd3b-48cbacfeb305.-.01.mp4

[ramyaram2092]

Hello @ypan710 the functionality works as expected.

PR-438.mp4

No errors on the console as well .
Approving the PR on the same note

[one-community]

Thank you all, this one is low risk, merged! Thanks for all your excellent reviews!