Carlos anniversary celebrated #1128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgomezhub
added
the
High Priority - Please Review First
Ankuriboh
suggested changes
Oct 16, 2024
| reject, | ||
| }); | ||
| } else { | ||
| resolve('Email sending is disabled'); |
There was a problem hiding this comment.
We probably better to just disable the whole queue system instead of resolving each promise in the message queue. IMO, this change noticing email sending is disabled is probably irrelevant to the current scope through.
Comment on lines
+17
to
+25
| .then(result => { | ||
| console.log('Email sent successfully:', result); | ||
| res.status(200).send(`Email sent successfully to ${to}`); | ||
| }) | ||
| .catch(error => { | ||
| console.error('Error sending email:', error); | ||
| res.status(500).send('Error sending email'); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Not sure why these lines are needed since await emailSender(to, subject, html) is already captured by the try-catch block, and it is already awaited.
| @@ -74,6 +74,9 @@ const overviewReportHelper = function () { | |||
| _id: 1, | |||
| firstName: 1, | |||
| lastName: 1, | |||
| email: 1, | |||
| profilePic: 1, | |||
| createdDate:1, | |||
There was a problem hiding this comment.
I don't see the createdDate field is being used in frontend PR, please kindly correctly if I am wrong.
| @@ -14,8 +13,16 @@ const sendEmail = async (req, res) => { | |||
|
|
|||
| console.log('to', to); | |||
There was a problem hiding this comment.
console.log() should be removed or commented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This part of a new Report Page: Create Company Summary Dashboard for Admins requested by Jae.
Implements # (WBS)
Anniversary Celebrared Component
Related PRS (if any):
This Backend PR is related to FrontendPR#2722.
To test this backend PR you need to checkout the #2722 frontend PR.
…
Main changes explained:
…
How to test:
Screenshots or videos needed:
App features video:
https://www.loom.com/share/d4f75956df7b4ef6946dd17aa8bfa806?sid=fc6227af-88b0-41ec-b0bc-4613367dc07f