Crystal fix tasks of members are hidden when teams toggle is off #1127
Conversation
| _myTeam.members.forEach((teamMember) => { | ||
| if (!teamMember.userId.equals(userid)) teamMemberIds.push(teamMember.userId); | ||
| if (teamMember.userId.equals(userid) && teamMember.visible) hasTeamVisibility = true; |
There was a problem hiding this comment.
As long as the user that is requesting is the last user and was set as visible in settings, they could see all other users as well as their tasks. You didn't check if the user has necessary permission (i.e. if they're an Owner/Administrator/Manager).
| _myTeam.members.forEach((teamMember) => { | ||
| if (!teamMember.userId.equals(userid)) teamMemberIds.push(teamMember.userId); | ||
| }); | ||
| } |
There was a problem hiding this comment.
You can use teamMembersIds.push(_myTeam.members.filter(m => !m.userId.equals(userid)).map(m => m.userId)); for shorthand.
one-community
added
the
High Priority - Please Review First
Hello, @Ankuriboh did you set the visibility specifically from the Team page? How.to.set.team.member.visibility.s.toggle.mp4 |
Hi, thanks for the kindly reply. It could probably be some problems on my end. But I tried on frontend PR #2766 development preview, toggling off the "see all" option as an administrator wouldn't allow me others on the tasks page. Is this working as intended? Because the "see all" tips says that it does "NOT reduce visibility for Owner, Admin or Core Team roles". |
Description
Bug priority high
Related PRS (if any):
To test this backend PR you need to checkout the development frontend PR.
Main changes explained:
How to test:
git checkout crystal-followup-fix-so-tasks-of-members-are-hidden-with-the-teams-togglenpm install,npm run buildandnpm run startto run this PR locallyOwner role -> Can view other members tasks
Admin role -> Can view other members tasks
Core Team role -> Can view other members tasks
Manager role -> CANNOT view other members tasks
Volunteer role -> CANNOT view other members tasks
Volunteer role (user has 2 teams)-> CANNOT view other members tasks
Screenshots or videos of changes:
How to set team member visibility's toggle. (refer to video below)
How.to.set.team.member.visibility.s.toggle.mp4
Example of changes when testing user: Crystal Volunteer with Volunteer role. (refer to video below)
PR.1127.-.User.with.team.visibility.toggle.off.cannot.view.other.member.s.task.mp4