Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: update bls-eth-go-binary #3349

Merged
merged 1 commit into from
Oct 23, 2024
Merged

*: update bls-eth-go-binary #3349

merged 1 commit into from
Oct 23, 2024

Conversation

gsora
Copy link
Collaborator

@gsora gsora commented Oct 23, 2024

Recent DKG issues may be due to an issue in bls-eth-go-binary, caused by an upstream bug in their dependencies.

Update to v1.36.1 which solves the issue.

Reference: herumi/bls-eth-go-binary#63

category: bug
ticket: none

Recent DKG issues may be due to an issue in
bls-eth-go-binary, caused by an upstream bug in their
dependencies.

Update to v1.36.1 which solves the issue.

Reference: herumi/bls-eth-go-binary#63
@github-actions github-actions bot added the branch-release PR or Issue linked to a release branch (not main) label Oct 23, 2024
Copy link

sonarcloud bot commented Oct 23, 2024

@pinebit
Copy link
Contributor

pinebit commented Oct 23, 2024

Looks like we will need to create a release-v1.1.2 branch, update app version there and then PR into that branch instead of main-v1.1? or is it fine to directly PR to main-v1.1? I am confused what we allow and what not :)

@gsora
Copy link
Collaborator Author

gsora commented Oct 23, 2024

If you look at the history of main-v1.1, when we released v1.1.1 we simply pushed a new commit on that branch.

Github actions will take care of fixing the version string at compile time.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.70%. Comparing base (dc848df) to head (56bab9b).
Report is 1 commits behind head on main-v1.1.

Additional details and impacted files
@@              Coverage Diff              @@
##           main-v1.1    #3349      +/-   ##
=============================================
- Coverage      57.74%   57.70%   -0.04%     
=============================================
  Files            211      211              
  Lines          30398    30398              
=============================================
- Hits           17552    17540      -12     
- Misses         10965    10972       +7     
- Partials        1881     1886       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pinebit
Copy link
Contributor

pinebit commented Oct 23, 2024

If you look at the history of main-v1.1, when we released v1.1.1 we simply pushed a new commit on that branch.

Github actions will take care of fixing the version string at compile time.

Thank you for clarifying!

@gsora
Copy link
Collaborator Author

gsora commented Oct 23, 2024

Manually merging to kick the v1.1.2 tag down the line.

@gsora gsora merged commit 7b7aa03 into main-v1.1 Oct 23, 2024
10 of 12 checks passed
@gsora gsora deleted the gsora/v1.1.2/bls-lib-update branch October 23, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-release PR or Issue linked to a release branch (not main)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants