Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output with roman numerals in cs2cs for lat-lon #4242

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jjimenezshaw
Copy link
Contributor

After this post
https://mapstodon.space/@jjimenezshaw/113017850151676527
we could have this "Easter egg". It is totally fine if it is not added.

It is only intended to work in output (not parsing input) for lat-lon.

I have not documented it in docs/source/cs2cs.rst. If you consider it should be in the documentation, let me know.

  • Tests added
  • Added clear title that can be used to generate release notes
  • Fully documented, including updating docs/source/*.rst for new API

@kbevers
Copy link
Member

kbevers commented Sep 2, 2024

While this is fun I am -1 on this. It's just extra clutter in the code without any real benefit.

@hobu
Copy link
Contributor

hobu commented Sep 2, 2024

I'm +1 to this. How else is someone going to be able to translate ancient roman coordinates? 😛

I would be -1 on roman coordinate locale support however 😉

return five + one + one + one;
case (9):
return one + ten;
default:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhmmm, I do not now if it is a flaw, or a feature. It was implemented in a way that 0 uses no-symbol. It would be strange something like d9'12"M , o even d'"S d'"OC for null island. But at the same time I like it even more, because it shows how roman numerals work (or not work).

@kgjenkins
Copy link

Unless the Roman Empire is going to step up and commit to funding the ongoing maintenance of this feature, I'd be wary of adding support for this proprietary notation that lacks an official publicly available specification. Also, in my experience, the Empire is really bad about returning e-mails or responding to questions. I'm not even sure if they are fully staffed anymore.

@skandalfo
Copy link

What have the Romans ever done for us?

@jjimenezshaw
Copy link
Contributor Author

What have the Romans ever done for us?

Apart from the sanitation, the medicine, education, wine, public order, irrigation, roads, the freshwater system, and public health… what have the Romans ever done for us?

@cffk
Copy link
Contributor

cffk commented Oct 10, 2024

I'm -1 on this too (sorry!). It's awkwardly jimmying an obsolete counting system (no zero, no negative numbers, no fractions) into a modern application. I fear it would also invite other silly PRs.

While I'm on the subject, does PROJ support centesimal degrees? This was (still is?) used for surveying in some parts of Europe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants