[16.0][FIX] web_advanced_search: Fixed changes from code editor not propagated #2964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Propagate changes in the debug mode domain editor to the domain itself. TT51315
|
Hi @ivantodorovich, |
pedrobaeza
reviewed
Oct 16, 2024
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 95bf1c6. Thanks a lot for contributing to OCA. ❤️ |
There was a problem hiding this comment.
Ok to this PR.
Only comment that the "add new value" option does not work correctly, I understand that this problem is different from the one solved by this PR and that functionally it is not important because the only way to use the "in" operator is using the debug mode.
But as I have detected it in my functional review, I leave it commented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propagate changes in the debug mode domain editor to the domain itself.
cc @Tecnativa TT51315
please review @CarlosRoca13 @carlosdauden