Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX][17.0] date_range : error opening conditional on studio #914

Closed
wants to merge 1 commit into from
Closed

[FIX][17.0] date_range : error opening conditional on studio #914

wants to merge 1 commit into from

Conversation

micheledic
Copy link

Fixes issue #909

@OCA-git-bot
Copy link
Contributor

Hi @lmignon,
some modules you are maintaining are being modified, check this out!

@micheledic
Copy link
Author

micheledic commented Jul 9, 2024 •
edited
Loading

@DavidBForgeFlow @LoisRForgeFlow ping

@micheledic
Copy link
Author

@DavidBForgeFlow @LoisRForgeFlow @lmignon we need this fix in our production env

@micheledic micheledic force-pushed the 17.0_date_range_fix_conditional_studio branch from 0a362f3 to 0dfd12e Compare July 18, 2024 14:39
@micheledic micheledic force-pushed the 17.0_date_range_fix_conditional_studio branch from 0dfd12e to 7e9636e Compare August 9, 2024 14:40
@CLEBORGNEAPIK
Copy link

Test ok

@micheledic
Copy link
Author

Any news? The Issue Is still on production

@micheledic
Copy link
Author

@pedrobaeza can you check ?

@pedrobaeza pedrobaeza added this to the 17.0 milestone Oct 8, 2024
@pedrobaeza
Copy link
Member

Sorry, not using Studio, and the changes seem very wide.

@micheledic
Copy link
Author

micheledic commented Oct 8, 2024 •
edited
Loading

Sorry, not using Studio, and the changes seem very wide.

who can check this ? the bug is still there, if somebody open studio on conditional field the error pops up
my PR only put a if above

salvorapi
salvorapi approved these changes Oct 10, 2024
View reviewed changes
Copy link

@salvorapi salvorapi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simahawk
Copy link
Contributor

simahawk commented Oct 11, 2024 •
edited
Loading

What about this smaller fix? #949
Yet I'm not sure it's complete.

@henrybackman
Copy link

I had missed the fix on the updateLeafOperator which is included here, thank you for this!
I have now added it in the other PR as well:

The fixes are similar, here the code section is wrapped in if-clause while the above PR just returns early. Impactful line changes are the same as here it is mostly indentation.

@lmignon
Copy link
Contributor

lmignon commented Oct 11, 2024

@henrybackman Can you close close this one in favor of #949 ?

@simahawk simahawk closed this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbrito gbrito gbrito approved these changes

@salvorapi salvorapi salvorapi approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
9 participants
@micheledic @OCA-git-bot @CLEBORGNEAPIK @pedrobaeza @simahawk @henrybackman @lmignon @gbrito @salvorapi