Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] pos_customer_required_fields: Migration to 16.0 #1249

Open
wants to merge 15 commits into
base: 16.0
Choose a base branch
from

Conversation

LaetitiaElabore
Copy link

@petrus-v
migration of pos_customer_required_fields from 12.0 to 16.0 (with commits history)

petrus-v and others added 14 commits October 1, 2024 14:41
Ensure desired fields are collect on customer Pos Order
In case there is no required field we don't want to
lock user on payment screen.

As required fields list is stored in string variable
spliting an empty string return an array of one empty
string which would return one missing field which
is locking users
Currently translated at 10.0% (1 of 10 strings)

Translation: pos-12.0/pos-12.0-pos_customer_required_fields
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_customer_required_fields/it/
Currently translated at 100.0% (10 of 10 strings)

Translation: pos-12.0/pos-12.0-pos_customer_required_fields
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_customer_required_fields/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-12.0/pos-12.0-pos_customer_required_fields
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_customer_required_fields/
Comment on lines 17 to 18
"base",
"base_setup",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't understand that addition. could you elaborate ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, I think it's just a mistake, I remove it

@LaetitiaElabore LaetitiaElabore force-pushed the 16.0-mig-pos_customer_required_fields branch from 3a1a0be to e4196f2 Compare October 1, 2024 13:30
@LaetitiaElabore LaetitiaElabore changed the title 16.0 mig pos customer required fields [16.0][MIG] pos_customer_required_fields: Migration to 16.0 Oct 3, 2024
@LaetitiaElabore LaetitiaElabore force-pushed the 16.0-mig-pos_customer_required_fields branch from e4196f2 to f9e826e Compare October 4, 2024 09:32
Copy link

@b0g b0g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ! OK

Comment on lines +65 to +71
.. figure:: https://raw.githubusercontent.com/OCA/pos/16.0/pos_customer_required_fields/static/description/pos_edit_customer.png

If you choose an existing partner with missing informations
while validating the payment you will be ask to collect missing
customer informations.

.. figure:: https://raw.githubusercontent.com/OCA/pos/16.0/pos_customer_required_fields/static/description/pos_customer_missing_fields.png
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This links are broken,

Beside that I tested the module and it work as expected !

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @b0g for the review and the feedback. I’ll fix the broken links.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose the broken link is normal until the branch is not merged!

Copy link
Contributor

@petrus-v petrus-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good to me. Probably some part of the documentation/screenshot are out of date!

Well done :)

@@ -0,0 +1,4 @@
# from . import res_partner
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line seems useless

Suggested change
# from . import res_partner

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @petrus-v for the feed back, I have just pushed the modification you suggested (and added some modification in translation files)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a screenshot of v12 has been replaced by one of v16

@LaetitiaElabore LaetitiaElabore force-pushed the 16.0-mig-pos_customer_required_fields branch from f9e826e to 38c31ce Compare October 9, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants