Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][ADD] pos_partner_firstname_required: New module pos_partner_firstname_required #1247

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from
Open

[17.0][ADD] pos_partner_firstname_required: New module pos_partner_firstname_required #1247

wants to merge 1 commit into from

Conversation

peluko00
Copy link

The module put the firstname required on POS partner view.

cc https://github.com/APSL 161168
@miquelalzanillas @lbarry-apsl @javierobcn @mpascuall @BernatObrador @ppyczko please review

mpascuall
mpascuall approved these changes Sep 30, 2024
View reviewed changes
Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

BernatObrador
BernatObrador approved these changes Sep 30, 2024
View reviewed changes
Copy link

@BernatObrador BernatObrador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

ppyczko
ppyczko approved these changes Sep 30, 2024
View reviewed changes
Copy link

@ppyczko ppyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BernatObrador BernatObrador BernatObrador approved these changes

@mpascuall mpascuall mpascuall approved these changes

@ppyczko ppyczko ppyczko approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@peluko00 @OCA-git-bot @BernatObrador @mpascuall @ppyczko