Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Minimum Python version Odoo 12 #39

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SirTakobi
Copy link

@SirTakobi SirTakobi commented Dec 16, 2022

Minimum version should be 3.5:

Odoo requires Python 3.5 or later to run

(ref. https://www.odoo.com/documentation/12.0/administration/install.html#python)

I have tried to remove the setuptools constraint too, it might be no more needed

This will need to be coordinated with other changes in https://github.com/OCA/oca-addons-repo-template/blob/510592efb895bc586a22d1808d72b7125b645d86/src/.github/workflows/%7B%25%20if%20ci%20%3D%3D%20'GitHub'%20%25%7Dtest.yml%7B%25%20endif%20%25%7D.jinja#L19

@SirTakobi
Copy link
Author

The Chrome installation error might be related to https://support.google.com/chrome/thread/192592808

@SirTakobi
Copy link
Author

@sbidoul other than the Chrome error (should be temporary), any opinion about the Python version change?
I'm afraid it is a pretty big change, but maybe it was already discussed and 3.6 had been chosen for some reason I don't know

@sbidoul
Copy link
Member

sbidoul commented Dec 16, 2022

Ow I had not received notifications of this failing.

This can be fixed by running the job on ubuntu-20.04 instead of ubuntu-latest for python <3.8.

@sbidoul
Copy link
Member

sbidoul commented Dec 16, 2022

@SirTakobi
Copy link
Author

Ow I had not received notifications of this failing.

This can be fixed by running the job on ubuntu-20.04 instead of ubuntu-latest for python <3.8.

Thanks, I have pinned the Ubuntu version but that does not appear to be the issue for chrome download

@SirTakobi SirTakobi force-pushed the patch-1 branch 3 times, most recently from 9152628 to e934242 Compare December 16, 2022 11:27
@@ -10,7 +10,7 @@ on:

jobs:
main:
runs-on: ubuntu-latest
runs-on: ${{matrix.machine}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I misled you. There is no need to change this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note: the PR is in draft because I still have to fix the CI (as I wrote, I hope the signature error is only temporary).
I only pinged you for:

any opinion about the Python version change?
I'm afraid it is a pretty big change, but maybe it was already discussed and 3.6 had been chosen for some reason I don't know

@SirTakobi SirTakobi force-pushed the patch-1 branch 2 times, most recently from c9fbd53 to 32d7e81 Compare December 16, 2022 11:46
@sbidoul
Copy link
Member

sbidoul commented Dec 16, 2022

any opinion about the Python version change?

Well that risks making some branches red, and I'd say it is late to change that for such an old version.

TBH, python version compatibility with Odoo is a bit of a mess. It's very hard to get a reliable information about which python versions are really supported. So we look at which python version is used on Odoo runbot and odoo.sh and test with that in OCA.

@SirTakobi
Copy link
Author

any opinion about the Python version change?

Well that risks making some branches red, and I'd say it is late to change that for such an old version.

TBH, python version compatibility with Odoo is a bit of a mess. It's very hard to get a reliable information about which python versions are really supported. So we look at which python version is used on Odoo runbot and odoo.sh and test with that in OCA.

What do you mean really supported?
The documentation might be wrong/not updated, but the truth is in the code too: Odoo 12.0, should be able to run at least in 3.5 because it is in https://github.com/odoo/odoo/blob/271b9468c999454527f106b4db177665afeef8ca/setup.py#L59.

@SirTakobi SirTakobi force-pushed the patch-1 branch 2 times, most recently from 5744f46 to e94afe4 Compare January 2, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants