[16.0][FIX] l10n_es_irnr: Assign core tax_groups to taxes that had template… #3791
+37
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
reviewed
Oct 22, 2024
| UPDATE account_tax SET tax_group_id = | ||
| (SELECT id FROM account_tax_group WHERE name::text LIKE '%Retenciones 0\%%') | ||
| WHERE name IN ( | ||
| 'Retenciones a cuenta IRPF No residentes no-UE exento por convenio', |
There was a problem hiding this comment.
Mejor que evites esta comparación. Enlaza con ir_model_data y utiliza el XML-ID.
aritzolea
force-pushed
the
16.0-fix-l10n_es_irnr-non_existing_tax_group_on_taxes
branch
from
6c51fc8
to
ca67e60
Compare
pedrobaeza
reviewed
Oct 22, 2024
| retenciones_24 = env.ref("l10n_es.tax_group_retenciones_24") | ||
| retenciones_19 = env.ref("l10n_es.tax_group_retenciones_19") | ||
| retenciones_0 = env.ref("l10n_es.tax_group_retenciones_0") | ||
| env["ir.model.data"].search( |
There was a problem hiding this comment.
Hay que ser elegante, hombre! Haz un bucle con repetiendo este código teniendo una lista de entrada de cada XML-ID y detino como datos variables.
There was a problem hiding this comment.
Hecho, lo he reducido bastante
… removed from module
aritzolea
force-pushed
the
16.0-fix-l10n_es_irnr-non_existing_tax_group_on_taxes
branch
from
ca67e60
to
b89f8a7
Compare
pedrobaeza
approved these changes
Oct 22, 2024
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 5fadee3. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… removed from module
Nos ha salido el siguiente error:
cc. @ljsalvatierra-factorlibre @edlopen @pedrobaeza