[17.0][MIG] website_sale_product_attachment #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… website This module lets you publish downloadable attachments in a product page. This is useful if you want to publish firmwares, manuals, specs, warranties, or whatever document related to the product. @Tecnativa TT20984 TT23657
… names Without this fix, the order in which attachments were displayed couldn't be predictable. Now, it's as expected by user: by name. Also the thumbnails got stretched when the attachment had a long name. @Tecnativa TT24437
Currently translated at 100.0% (9 of 9 strings) Translation: e-commerce-12.0/e-commerce-12.0-website_sale_product_attachment Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_sale_product_attachment/es/
Currently translated at 33.3% (3 of 9 strings) Translation: e-commerce-12.0/e-commerce-12.0-website_sale_product_attachment Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_sale_product_attachment/fr/
Currently translated at 100.0% (9 of 9 strings) Translation: e-commerce-12.0/e-commerce-12.0-website_sale_product_attachment Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_sale_product_attachment/fr/
Currently translated at 33.3% (3 of 9 strings) Translation: e-commerce-12.0/e-commerce-12.0-website_sale_product_attachment Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_sale_product_attachment/nl/
Currently translated at 100.0% (9 of 9 strings) Translation: e-commerce-12.0/e-commerce-12.0-website_sale_product_attachment Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_sale_product_attachment/ca/
…sudo In v13, there's no general read ACL for public files, so we need to get filenames and file type using sudo. The download is performed normally due to the public=True field in the attachments.
On previous version, attachments had 2 fields for adding both attachment name and file name. Now on v13, there's only one, that is fille with the file name. On initial migration, it was considered that this field is enough, but putting file names on the website product page can be ugly, limited and confusing, so we are adding here a new field to store the name we want to give it for the website e-commerce product page. It also includes migration script for recovering the old information if coming from v12.
Currently translated at 100.0% (12 of 12 strings) Translation: e-commerce-13.0/e-commerce-13.0-website_sale_product_attachment Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_product_attachment/ca/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: e-commerce-16.0/e-commerce-16.0-website_sale_product_attachment Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_product_attachment/
Currently translated at 100.0% (12 of 12 strings) Translation: e-commerce-16.0/e-commerce-16.0-website_sale_product_attachment Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_product_attachment/es/
|
Please include #944 and check CI. |
Currently translated at 100.0% (12 of 12 strings) Translation: e-commerce-16.0/e-commerce-16.0-website_sale_product_attachment Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_product_attachment/it/
…justment - Make the alert and table placed correctly with the grid display, avoiding overlap and poor placement of the elements in the view.
dalonsod
force-pushed
the
17.0-mig-website_sale_product_attachment
branch
from
37b0171
to
cdc6985
Compare
#944 cherry-picked 👍 Regarding to test issue, I'm newbie in web tour tests, I might need some help or links with an example. I've inspected code anyway and haven't found which the problem could be. @yajo @victoralmau could you help me? Thanks! |
|
According to the error you find in logs: It looks like the wanted tour isn't even loaded. Maybe it's because its js definition is lost, or maybe because its trigger condition is never met. If you run odoo with |
Anxo82
force-pushed
the
17.0-mig-website_sale_product_attachment
branch
2 times, most recently
from
cf71567
to
13f9a37
Compare
Anxo82
force-pushed
the
17.0-mig-website_sale_product_attachment
branch
from
13f9a37
to
7974e6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standar migration.