Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] website_sale_invoice_address module #837

Merged
merged 7 commits into from
Sep 5, 2023
Merged

[16.0][MIG] website_sale_invoice_address module #837

merged 7 commits into from
Sep 5, 2023

Conversation

suker
Copy link

@suker suker commented Sep 1, 2023

Migration of module from 15.0 to 16.0

chienandalu
chienandalu suggested changes Sep 1, 2023
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @suker !

cc @Tecnativa @pilarvargas-tecnativa TT44888

tour fix suggestion:

website_sale_invoice_address/static/src/js/website_sale_invoice_address_tour.js Outdated

var steps = [
{
trigger: "a:contains('Large Meeting Table')",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can fix your test

Suggested change
trigger: "a:contains('Large Meeting Table')",
trigger: "a:contains('Chair floor protection')",

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, thanks.

@suker suker force-pushed the 16.0-mig-website_sale_invoice_address branch from 768a122 to ad44b6e Compare September 1, 2023 12:59
@suker suker mentioned this pull request Sep 1, 2023
Open
33 tasks
chienandalu
chienandalu approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@pedrobaeza
Copy link
Member

/ocabot migration website_sale_invoice_address

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Sep 1, 2023
@liebana
Copy link

liebana commented Sep 5, 2023

Functional review, LGTM

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-837-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 5, 2023
@OCA-git-bot
Merge PR #837 into 16.0
6f2e92d 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-837-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-837-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 45bc198 into OCA:16.0 Sep 5, 2023
4 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b0d5381. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chienandalu chienandalu chienandalu approved these changes

@liebana liebana liebana approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
7 participants
@suker @pedrobaeza @liebana @OCA-git-bot @chienandalu @pilarvargas-tecnativa @Ivorra78