Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][ADD] acount_move_tags: add module #1809

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

joepsanders
Copy link

No description provided.

@chrisb-c01
Copy link

LGTM

@OCA/accounting-maintainers can you review?

@pedrobaeza pedrobaeza changed the title [ADD] acount_move_tags: add module [17.0][ADD] acount_move_tags: add module Oct 5, 2024
@pedrobaeza
Copy link
Member

Thanks for the contribution. Please avoid plurals on module names as stated in https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#modules. You can call it account_move_tag for example (although we know that it can be more than one tag). It's a technical name, and thus, it shouldn't reflect the "language correction". Why plurals should be avoided is for avoiding frequent typos typing the module name. Imagine an extension module account_move_tags_images, and then account_move_tags_images_relative, and so on: you'll end up putting s where it's not and not putting them when it should.

Please also squash both commits.

@joepsanders joepsanders force-pushed the cf01-083-account-move-tags-oca branch from 360b15c to 69fe028 Compare October 6, 2024 08:48
@joepsanders
Copy link
Author

Thanks for the contribution. Please avoid plurals on module names as stated in https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#modules. You can call it account_move_tag for example (although we know that it can be more than one tag). It's a technical name, and thus, it shouldn't reflect the "language correction". Why plurals should be avoided is for avoiding frequent typos typing the module name. Imagine an extension module account_move_tags_images, and then account_move_tags_images_relative, and so on: you'll end up putting s where it's not and not putting them when it should.

Please also squash both commits.

Thanks @pedrobaeza for the feedback and explanation! Review of the updated module is much appreciated :)

@pedrobaeza pedrobaeza added this to the 17.0 milestone Oct 7, 2024
"category": "Hidden",
"version": "17.0.1.0.0",
"depends": ["account"],
"license": "LGPL-3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not putting it AGPL-3 for avoiding private extensions on this?

Copy link
Author

@joepsanders joepsanders Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Pedro, we'll dive into the licensing question ;). Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants