[14.0][FIX] stock_picking_invoicing: Inform field invoice_state in Stock Rule #1782
Conversation
There was a problem hiding this comment.
sorry for the delay. The why can be seen here https://github.com/OCA/account-invoicing/pull/1025/files#r1686701138
BTW this is future proof as _get_custom_move_fields is present even in v18.
|
This PR has the |
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
@rvalyi your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1782-by-rvalyi-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
The error in the merge command seems not related with this PR https://github.com/OCA/account-invoicing/actions/runs/11469170392/job/31915851268#step:8:726 2024-10-22 22:03:10,750 564 ERROR odoo odoo.addons.account_invoice_pricelist.tests.test_account_move_pricelist: FAIL: TestAccountMovePricelist.test_account_invoice_fixed_pricelist_without_discount_secondary_currency
Traceback (most recent call last):
File "/__w/account-invoicing/account-invoicing/account_invoice_pricelist/tests/test_account_move_pricelist.py", line 319, in test_account_invoice_fixed_pricelist_without_discount_secondary_currency
self.assertAlmostEqual(invoice_line.price_unit, 65.41)
AssertionError: 100.0 != 65.41 within 7 places
2024-10-22 22:03:10,958 564 ERROR odoo odoo.addons.account_invoice_pricelist.tests.test_account_move_pricelist: FAIL: TestAccountMovePricelist.test_account_invoice_pricelist_with_discount_secondary_currency
Traceback (most recent call last):
File "/__w/account-invoicing/account-invoicing/account_invoice_pricelist/tests/test_account_move_pricelist.py", line 295, in test_account_invoice_pricelist_with_discount_secondary_currency
self.assertAlmostEqual(invoice_line.price_unit, 58.87)
AssertionError: 90.00000000000004 != 58.87 within 7 places
2024-10-22 22:03:11,360 564 ERROR odoo odoo.addons.account_invoice_pricelist.tests.test_account_move_pricelist: FAIL: TestAccountMovePricelist.test_account_invoice_pricelist_without_discount_secondary_currency
Traceback (most recent call last):
File "/__w/account-invoicing/account-invoicing/account_invoice_pricelist/tests/test_account_move_pricelist.py", line 303, in test_account_invoice_pricelist_without_discount_secondary_currency
self.assertAlmostEqual(invoice_line.price_unit, 65.41)
AssertionError: 100.0 != 65.41 within 7 places |
mbcosta
force-pushed
the
14.0-FIX-invoice_state_stock_rule
branch
from
49c98c1
to
17a76f4
Compare
|
@rvalyi after testing for while suddenly the error stop to happening, I'm not sure the reason but suspect it could be related by the DATE, the lines of the object product.pricelist has the fields date_start and date_end, the tests of the module don't inform the values, but this information is used in methods like _compute_price_rule_get_items and others, but as the error stop for now it's not possible be sure about. |
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 0a2b7d9. Thanks a lot for contributing to OCA. ❤️ |
Inform field invoice_state in Stock Rule
https://github.com/OCA/OCB/blob/14.0/addons/stock/models/stock_rule.py#L259
def _get_custom_move_fields(self): """ The purpose of this method is to be override in order to easily add fields from procurement 'values' argument to move data. """ return []Review of #1025
Also remove License Header in init file with only imports
cc @rvalyi @renatonlima @kevinkhao