[IMP][16.0] Add hooks to account_invoice_pricelist #1511
Conversation
gdgellatly
force-pushed
the
gdg-account_invoice_pricelist_hooks
branch
2 times, most recently
from
3cb54a0
to
f30328c
Compare
|
Note: Leaving in Draft until I have a fresh migration to retest against. |
|
This PR has the |
|
In testing with large data, the existing call to compute pricelist_id triggers the write method of account.move, which subsequently calls _sync_dynamic_lines. In this database, and presumably others, this causes a Readonly exception on posted moves. I have changed this PR, to purely populate pricelist_id and to do so via psql. In test, in database with around 7m account.moves installation took around 2-3 minutes. |
|
I have now tested this with a load of production data successfully in a migration |
There was a problem hiding this comment.
Hi @gdgellatly, please squash your commits.
The changes made LGTM.
Do we not squash on merge? |
|
Hi @gdgellatly, Can you please rebase and merge? Thank you |
|
/ocabot rebase |
|
Congratulations, PR rebased to 16.0. |
OCA-git-bot
force-pushed
the
gdg-account_invoice_pricelist_hooks
branch
from
95e33e8
to
70926ee
Compare
|
Closing as on review, not multicompany safe and no time to correct. |
Before this change installing this module on a database with only a few million account_moves would take upwards of an hour. The vast majority of the installation time was taken by the newly enabled tracking on the pricelist_id field.
After this change we precreate the pricelist_id column and then post installation update only those moves required with tracking disabled.