This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
Added the ability to supply baseNuspecFile to the CreatePackage task #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzu
suggested changes
Dec 1, 2017
There was a problem hiding this comment.
Hi there!
Thanks for taking the time to add this feature. Looks really useful!
Could you add some unit tests that exercise this feature.? For example, for the dependency groups, a test would need to make sure a package can be created when both generated and base spec have the same dependency group.
Thanks again!
| @@ -140,12 +153,12 @@ select item.GetNuGetTargetFramework())) | |||
| definedDependencyGroups.Add(targetFramework.GetFrameworkString(), | |||
| new PackageDependencyGroup(targetFramework, Array.Empty<PackageDependency>())); | |||
|
|
|||
| manifest.Metadata.DependencyGroups = definedDependencyGroups.Values; | |||
| manifest.Metadata.DependencyGroups = definedDependencyGroups.Values.Concat(manifest.Metadata.DependencyGroups); | |||
There was a problem hiding this comment.
II think what would be needed is more of a merge here, than a concat, since the concat would end up with duplicate groups? Is that supported in the nuspec?
kzu
added a commit
to kzu/NuGet.Build.Packaging
that referenced
this pull request
Dec 1, 2017
The package cache lower cases all paths, which no longer matches the package id as we were previously doing. We need to match in a case- insensitive way therefore for private assets matching to succeed. This fixes a broken unit test that was blocking two PRs NuGet#151 and NuGet#150. Also, fix the nuget package versions at the time of this test authoring, so we don't accidentally break if newer packages ever change and cause the expectations to fail.
kzu
added a commit
that referenced
this pull request
Dec 1, 2017
The package cache lower cases all paths, which no longer matches the package id as we were previously doing. We need to match in a case- insensitive way therefore for private assets matching to succeed. This fixes a broken unit test that was blocking two PRs #151 and #150. Also, fix the nuget package versions at the time of this test authoring, so we don't accidentally break if newer packages ever change and cause the expectations to fail.
ghost
deleted a comment from
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is possible in NuProj projects, I've duplicated the functionality.