python3Packages.gensim: fix build with scipy 1.13 #308620
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python3Packages.scipy update to 1.13.0 removed triu. Patch from upstream commit replaces it with numpy.triu if import from scipy.linalg.triu fails. piskvorky/gensim#3524 scipy/scipy#19674
|
Result of 12 packages failed to build:
12 packages built:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
python3Packages.scipyupdate to 1.13.0 removed deprecatedscipy.linalg.triu.This PR adds patch from upstream commit that replaces it with
numpy.triuif import fromscipy.linalg.triufails.Currently there is no release tag with that fix.
See:
piskvorky/gensim#3524
scipy/scipy#19674
Fixes current build on unstable with python 3.11 (
python311Packages.gensim):https://hydra.nixos.org/build/256674931
Currently does not fix build with python 3.12, as it fails on building dependency -
python312Packages.smart-open:https://hydra.nixos.org/build/256692770
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.