-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
agdaPackages.standard-library: 1.7.3 -> 2.0 #273765
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add the --include-deprecated
flag on the call to GenerateEverything.hs
. This means that if you use a deprecated module the warnings actually show up instead of giving an error about things not being built
b591fd6
to
38baa1f
Compare
It seems that this would break |
Upstream issue is agda/agda-categories#405, if there is no progress in, say, a week or so, I'm happy to merge. But if there is some promising progress, I think we should bump both libraries jointly. |
It's worth noting that this version is a large non backwards compatible change |
Sure, I wasn't planning to merge this right away. |
Updated the functional-linear-algebra package to work with the 2.0 version of the library. Thanks for the heads up. |
Can confirm HEAD builds. Are you planning to make a new release or should we bump to HEAD? |
Just pushed tag |
agda-categories has a new release, so we can probably go ahead with this update now |
Bumped agda-categories. No response from agdarsec, so we might as well mark it broken. I had to increase the maximum heap for building agda-categories after the update. Weirdly enough, this is the third Agda project I know of that has recently started exceeding the maximum heap size (the other two being agda-unimath and 1lab), but this doesn't seem to be correlated to the Agda 2.6.4.1 bump... Does anyone have an explanation, or is this just a funny coincidence? |
It might be worth checking whether this is due to the recent agda version bump, the agda-stdlib version bump, or the agda-categories version bump. I have no explanation, though. |
Could it also be a ghc change? I always remember agda being happy to consume way more than 4gb ram |
https://github.com/agda/agda-stdlib/blob/v2.0/CHANGELOG.md
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.