Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nufmt: init at 0.1.0 #257297

Closed
wants to merge 3 commits into from
Closed

nufmt: init at 0.1.0 #257297

wants to merge 3 commits into from

Conversation

IogaMaster
Copy link
Contributor

@IogaMaster IogaMaster commented Sep 25, 2023 •
edited
Loading

Description of changes

Created package nufmt and added myself as a maintainer.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@IogaMaster
Copy link
Contributor Author

If needed I will change this to unstable-2023-09-25

@IogaMaster
Copy link
Contributor Author

I'll change

@IogaMaster
Copy link
Contributor Author

Okay

@IogaMaster
Copy link
Contributor Author

Is there anything else I need to do?

@IogaMaster
Copy link
Contributor Author

IogaMaster commented Sep 27, 2023 •
edited
Loading

Added a flake to nufmt
nushell/nufmt#41

@IogaMaster
Copy link
Contributor Author

FYI I am working on a major rewrite of nufmt, although this would be fine to merge I'll update it in nixpkgs when it's time.
nushell/nufmt#49

We now have a flake as well

@IogaMaster
Copy link
Contributor Author

@Mic92 What do I need to do now?

@siph
Copy link
Member

siph commented Oct 22, 2023

Result of nixpkgs-review pr 257297 run on x86_64-linux 1

1 package built:
  • nufmt

@siph
Copy link
Member

siph commented Oct 22, 2023

This builds and I was able to format an .nu file, but you should rename from 0.1.0 like you suggested earlier.

@IogaMaster
Copy link
Contributor Author

@siph Okay, done

@siph
Copy link
Member

siph commented Oct 22, 2023

You should also update/squish your commit message to nufmt: init at unstable-2023-09-25.

@IogaMaster
Copy link
Contributor Author

Slight issue, there are many commits in between those. As I updated to keep in line with the master branch

@IogaMaster
Copy link
Contributor Author

As I have made a mistake I am going to reopen this pr

@IogaMaster IogaMaster closed this Oct 31, 2023
@IogaMaster
Copy link
Contributor Author

@siph
New pr
#264500

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IogaMaster @siph @Mic92