Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RPM specification file #50

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add RPM specification file #50

wants to merge 2 commits into from

Conversation

mmerklinger
Copy link
Contributor

This PR adds a RPM specification file to build the package on Fedora.

  • Adds RPM specification file python3-nitrokey.spec and patch protobuf.patch.
  • Adds a CI pipeline job to make sure the package versions in pyproject.toml and python3-nitrokey.spec are the same.

The new CI job needs to run on a Fedora container, because the RPM tools ob Debian don't understand the contained RPM macros. For new releases the version number must be raised in pyproject.toml and python3-nitrokey.spec.

@mmerklinger mmerklinger self-assigned this Oct 29, 2024
@mmerklinger mmerklinger marked this pull request as ready for review October 29, 2024 17:12
@robin-nitrokey
Copy link
Member

How will the rpm file be used? Will we add a CI job to this repository that builds the package?

@mmerklinger
Copy link
Contributor Author

No, the package is build on Fedora COPR. In COPR we add a project, which is a RPM repository. In this RPM repository we reference the RPM specification file in this Git repository. From COPR we can request new builds of the package.

@mmerklinger
Copy link
Contributor Author

It would be probably also good to make the new version check mandatory to pass in the CI pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants