Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten nk3 and trussed modules #17

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Flatten nk3 and trussed modules #17

merged 1 commit into from
Jul 26, 2024

Conversation

robin-nitrokey
Copy link
Member

Previously, we had many small modules under nk3 and trussed that only contained one or two (public) items. This patch makes these modules private and re-exports their public content from the parent module.

Fixes: #9


This means that all modules marked with * are now removed from the public API:

  nitrokey
  nitrokey.nk3
* nitrokey.nk3.bootloader
* nitrokey.nk3.device
  nitrokey.nk3.secrets_app
  nitrokey.nk3.updates
  nitrokey.nkpk
  nitrokey.trussed
  nitrokey.trussed.admin_app
* nitrokey.trussed.base
* nitrokey.trussed.bootloader
* nitrokey.trussed.bootloader.lpc55
* nitrokey.trussed.bootloader.nrf52
* nitrokey.trussed.device
* nitrokey.trussed.exceptions
  nitrokey.trussed.provisioner_app
* nitrokey.trussed.utils
  nitrokey.updates

Previously, we had many small modules under nk3 and trussed that only
contained one or two (public) items.  This patch makes those modules
private and re-exports their public content from the parent module.

Fixes: #9
@robin-nitrokey robin-nitrokey merged commit ecd4389 into main Jul 26, 2024
14 checks passed
@robin-nitrokey robin-nitrokey deleted the modules branch July 26, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review module structure
2 participants