parsetoml: support compiling with strictFuncs again #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nim 1.6.0 added an opt-in for the
strictEffects
behavior, which will become the default in Nim 2.0.Commit bb90361 allowed Nim to compile parsetoml with strictEffects, but we could no longer compile with strictFuncs:
Add an override so that strictFuncs doesn't complain about the
func
. Simply changing thefunc
to aproc
doesn't work.Note that the definition of strictFuncs was recently changed.
Closes: #61
I've checked that this works for every combination of strictEffects and strictFuncs, with both Nim 1.6.12 and
devel
. I don't know if we want to make a change intimes.nim
too, but I think we want this PR either way (so that we can compile parsetoml with strictFuncs without waiting for a new Nim release).