did-simple: implement pubkey access with fixed size arrays #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheButlah
changed the base branch from
main
to
thebutlah/improve_decode_implement_pubkey
TheButlah
force-pushed
the
thebutlah/improve_decode_implement_pubkey
branch
from
0c19d66
to
f10c617
Compare
Base automatically changed from
thebutlah/improve_decode_implement_pubkey
to
thebutlah/encode_varint
May 19, 2024 06:58
TheButlah
force-pushed
the
thebutlah/encode_varint
branch
from
6d03ed4
to
0962abe
Compare
TheButlah
changed the base branch from
thebutlah/encode_varint
to
thebutlah/decode_varint
TheButlah
force-pushed
the
thebutlah/decode_varint
branch
2 times, most recently
from
f78960f
to
c92fb75
Compare
TheButlah
force-pushed
the
thebutlah/implement-pubkey-access
branch
from
3fd716e
to
32019d0
Compare
TheButlah
force-pushed
the
thebutlah/decode_varint
branch
from
c92fb75
to
b26145f
Compare
TheButlah
force-pushed
the
thebutlah/implement-pubkey-access
branch
3 times, most recently
from
7f6a1db
to
bb315cb
Compare
|
After getting feedback from @kayhhh that the api looks unecessarily complicated, I've dumbed it down and gotten rid of the fixed size arrays. |
TheButlah
force-pushed
the
thebutlah/implement-pubkey-access
branch
from
354dd6e
to
bb2d14e
Compare
TheButlah
force-pushed
the
thebutlah/implement-pubkey-access
branch
2 times, most recently
from
fb0054a
to
f58e99d
Compare
TheButlah
force-pushed
the
thebutlah/implement-pubkey-access
branch
from
f58e99d
to
1007fa0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased on #100, merge that first.I'm not sure about this PR. I may have overcomplicated things.The goal was to make it so that the pubkey is always returned as a reference to a fixed-size array.This is because key algos specify up front their length, so we want to show that we validated that length.
However, I'm not sure that the type machinery I made is user friendly. What are your thoughts @kayhhh @MalekiRe @Schmarni-Dev?