Pool connections using bb8 #115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheButlah
requested changes
Jun 22, 2024
| use eyre::{bail, ensure, Context, OptionExt}; | ||
| use async_trait::async_trait; | ||
| use eyre::{bail, ensure, eyre, Context, OptionExt}; | ||
| use eyre::{ContextCompat, Result}; |
There was a problem hiding this comment.
Prefer eyre::WrapErr instead of Context and eyre::OptionExt instead of ContextCompat
| async fn is_valid(&self, framed: &mut Self::Connection) -> Result<(), Self::Error> { | ||
| let framed = framed | ||
| .as_mut() | ||
| .wrap_err("connection was dropped due to panic")?; |
Comment on lines
+75
to
+76
| let framed = Framed::new(bi); | ||
| Ok(Some(framed)) |
There was a problem hiding this comment.
Suggested change
| let framed = Framed::new(bi); | |
| Ok(Some(framed)) | |
| Ok(Some(Framed::new(bi))) |
| async fn get_framed(&self) -> Result<DropConnectionOnPanic<'_>> { | ||
| let pooled_connection = self.pool.get().await.map_err(|e| match e { | ||
| bb8::RunError::User(eyre) => { | ||
| eyre.wrap_err("get from connection pool failed") |
There was a problem hiding this comment.
Suggested change
| eyre.wrap_err("get from connection pool failed") | |
| eyre.wrap_err("could not get framed stream from connection pool") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves from an async worker (bad abstraction) to a connection pool.
bb8does not have an obvious way to kill connections involved in a panic, so as a (hopefully temporary) workaround, a wrapper is used that checks for panics on drop and, if so, replaces the connection with aNonebefore it is returned to the pool, at which point it is identified as dead viahas_broken.Draft asit compiles but is not yet tested.