replicate: use bearer token instead of did #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheButlah
force-pushed
the
thebutlah/simplify-auth
branch
2 times, most recently
from
432599c
to
b7bb24e
Compare
TheButlah
force-pushed
the
thebutlah/simplify-auth
branch
from
b7bb24e
to
8fe1b9a
Compare
TheButlah
force-pushed
the
thebutlah/simplify-auth
branch
from
8fe1b9a
to
683a98a
Compare
|
Forcing merge due to lack of review. |
TheButlah
added a commit
that referenced
this pull request
Jun 20, 2024
I've updated the code to properly spawn a future that will start the tokio runtime and perform the necessary steps to connect to the replicate manager. Next step will be to use the newly connected manager resource to spawn an instance. The video showcases the UI flows and how connecting to a server that doesn't exist fails, but connecting to the one I start from the command line with a valid url succeeds. Rebased on #111 https://github.com/NexusSocial/nexus-vr/assets/6969415/c2d1ee2f-593a-4ee4-a3a7-bd39ccdcc569
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous DID stuff in the replicate crates were unecessary and too application specific. Its more useful to use a general bearer token, and leave how to validate that token and what its contents are up to the application.
A did-signed authentication attestation could just be a base64 signed message, and use that as the bearer token.