Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code signing #496

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Aug 1, 2023

Resolves #455

Signing requires the secrets PFX_BASE64 and PFX_KEY. Signing can be disabled completely by setting SignExecutable to false.

@erri120 erri120 added this to the v0.1 milestone Aug 1, 2023
@erri120 erri120 requested a review from halgari August 1, 2023 08:45
@erri120 erri120 self-assigned this Aug 1, 2023
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #496 (c638188) into main (295076e) will decrease coverage by 0.11%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #496      +/-   ##
==========================================
- Coverage   70.07%   69.97%   -0.11%     
==========================================
  Files         554      554              
  Lines       14832    14832              
  Branches     1034     1034              
==========================================
- Hits        10394    10379      -15     
- Misses       4173     4184      +11     
- Partials      265      269       +4     
Flag Coverage Δ
Linux 69.25% <ø> (-0.03%) ⬇️
Windows 69.06% <ø> (+0.01%) ⬆️
clean_environment_tests 69.97% <ø> (-0.10%) ⬇️
network_tests ?
networking_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

@halgari halgari merged commit e985aae into Nexus-Mods:main Aug 1, 2023
5 of 6 checks passed
@erri120 erri120 deleted the issue-455-code-signing branch August 2, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Investigate code-signing
2 participants