Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two bugs found in testing #2216

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Fix two bugs found in testing #2216

merged 1 commit into from
Oct 30, 2024

Conversation

halgari
Copy link
Collaborator

@halgari halgari commented Oct 30, 2024

This PR updates to the latest MnemonicDB release which fixes 2 major issues in the app:

  1. General performance - the GlobalCompare method in MnemonicDB was performing 2 allocations on every compare. This was having a massive impact on everything from reads to writes. This issue has been resolved
  2. Timestamp regression - we were storing transaction timestamps incorrectly, resulting in the 400 years from now bug in the UI

Resolves #2211, #2207

@halgari halgari marked this pull request as ready for review October 30, 2024 18:24
@halgari halgari merged commit 3a23441 into main Oct 30, 2024
14 of 15 checks passed
@halgari
Copy link
Collaborator Author

halgari commented Oct 30, 2024

Going to merge this without a review as all that's here is a deps upgrade

@halgari halgari deleted the fix-various-bugs branch October 30, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App Mod processing performance drop
1 participant