Improved: Empty State View #2162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2159 (good enough to consider it a 'fix' for now)
fixes #2160 (adds missing hyperlink)
For the shrinking issue, the following margin is reduced:
Currently shrinking the window does this:
With the PR it is shrunk down to
16(from128):The contents remain centered, 1:1 with before if not shrunk.
The movement of the title and link is still inconsistent, however that's due to an unrelated reason; the hyperlink is actually a button, and unlike the text, the button has a minimum size, and thus can't wrap around edges. Will leave to @insomnious to pick that one up since they volunteered.
Already got the thumbs up from @captainsandypants on Slack.