Library: Use new columns #2151
Merged
Library: Use new columns #2151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Al12rs
reviewed
Oct 9, 2024
src/Abstractions/NexusMods.Abstractions.NexusWebApi/Types/V2/GameId.cs
Outdated
Show resolved
Hide resolved
|
This PR conflicts with |
Al12rs
reviewed
Oct 9, 2024
Al12rs
reviewed
Oct 9, 2024
erri120
force-pushed
the
tree-columns-2
branch
from
9796ea1
to
4bd5e6c
Compare
|
This PR doesn't conflict with |
Al12rs
reviewed
Oct 10, 2024
There was a problem hiding this comment.
Code looks good, I ran into the
[ERROR] While commiting transaction|System.InvalidOperationException: Invalid UTF-8 sequence.
bug when testing mass deletions etc, that should be solved by #2154.
Would like to get that in first so this can be tested better.
erri120
force-pushed
the
tree-columns-2
branch
from
5236d21
to
1a02072
Compare
|
This PR conflicts with |
erri120
force-pushed
the
tree-columns-2
branch
from
1a02072
to
9acf06f
Compare
|
This PR doesn't conflict with |
Al12rs
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the composition aspect of the new system, there is quite the amount of boilerplate code.
TODO: