Fix off-screen row updates in the Library #2146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…led/removed from a loadout
erri120
requested changes
Oct 9, 2024
src/NexusMods.App.UI/Controls/TreeDataGrid/TreeDataGridAdapter.cs
Outdated
Show resolved
Hide resolved
src/NexusMods.App.UI/Pages/LibraryPage/FakeParentLibraryItemModel.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: erri120 <erri120@fossmailer.de>
…del.cs Co-authored-by: erri120 <erri120@fossmailer.de>
Co-authored-by: erri120 <erri120@fossmailer.de>
erri120
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The install/installed status of a row is dependent on the number of connect loadout items.
ObserveCountChanged()does not notify of the current count on a subscription (by default). So when a row was re-activated the installed status of the row defaulted to the status when it was last seen on screen, and would only update if the status changed again in the future. This PR addsnotifyCurrentCount:trueto these invocations to fix this problem.Also updates
GetCreatedAtso it no longer crashes Rx chains during deletion of entities.fixes: #2141 and #2140