Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for badge width with larger numbers #2133

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Fix for badge width with larger numbers #2133

merged 1 commit into from
Oct 8, 2024

Conversation

insomnious
Copy link
Collaborator

Part of #1733

  • Removed badge fixed width
  • Added quick design view model

@insomnious
Fix for badge width with larger numbers
c14a900 
Added design view model for testing
@insomnious insomnious requested a review from a team October 7, 2024 09:47
@insomnious insomnious self-assigned this Oct 7, 2024
Al12rs
Al12rs approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@Al12rs Al12rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test in action but code makes sense

@erri120 erri120 merged commit 91f2e97 into main Oct 8, 2024
10 checks passed
@erri120 erri120 deleted the fix/left-menu-badge-numbers branch October 8, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Al12rs Al12rs Al12rs approved these changes

Assignees

@insomnious insomnious

Labels
None yet
Projects
MVP
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@insomnious @Al12rs @erri120