Skip to content

Commit

Permalink
Update comments to handle feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
halgari committed Aug 2, 2023
1 parent e5dd01a commit 544b0c5
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/NexusMods.DataModel/Loadouts/LoadoutSyncronizer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,8 @@ public async ValueTask<IngestPlan> MakeIngestPlan(Loadout loadout, Func<Absolute
{
await EmitIngestReplacePlan(plan, planFile, existing);
}
// TODO: Fix this
// TODO: Fix this, it doesn't contain support for IGeneratedFile,
// once we re-design apply/ingest this should be implemented
continue;
}

Expand Down
4 changes: 4 additions & 0 deletions src/NexusMods.DataModel/ToolManager.cs
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,10 @@ public async Task<Loadout> RunTool(ITool tool, Loadout loadout, ModId? generated
generatedFilesMod = mod.Id;
}

// We don't yet properly support ingesting data. The issue is if a bad apply occurs, the ingest can
// delete files we don't yet have a way of recreating. Also we have no way to create branches, roll back the
// ingest, etc. in the loadout. So for now we just don't ingest.

//var ingestPlan = await _loadoutSynchronizer.MakeIngestPlan(loadout, _ => generatedFilesMod.Value, token);
//return await _loadoutSynchronizer.Ingest(ingestPlan, $"Updating {tool.Name} Generated Files");
return loadout;
Expand Down

0 comments on commit 544b0c5

Please sign in to comment.