Simplify Transpilation of $ with Extended Line Separator Support in cuDF Regex #11663
+63
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Suraj Aralihalli <suraj.ara16@gmail.com>
Signed-off-by: Suraj Aralihalli <suraj.ara16@gmail.com>
Signed-off-by: Suraj Aralihalli <suraj.ara16@gmail.com>
Signed-off-by: Suraj Aralihalli <suraj.ara16@gmail.com>
Signed-off-by: Suraj Aralihalli <suraj.ara16@gmail.com>
|
Can we confirm some of the behavior described in compatibility.md and update accordingly? |
Signed-off-by: Suraj Aralihalli <suraj.ara16@gmail.com>
Signed-off-by: Suraj Aralihalli <suraj.ara16@gmail.com>
Thank you for pointing it, I found another issue that is resolved by this PR. I've updated the guide and tests to reflect this. |
|
Build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11554, #7585
In cuDF, support for multiple newline characters was expanded from NEW_LINE (
\n) to include the following:\u0085)\u2028)\u2029)\r)\n)PR #17139 introduced this change to cuDf JNI with
RegexFlag::EXT_LINE. This PR simplifies the transpilation of$by changing the pattern from(?:\r|\u0085|\u2028|\u2029|\r\n)?$to the simpler(?:\r\n)?$and updates all functions to useRegexFlag::EXT_LINEwherever this transpilation occurs.This PR also drops support for
$\zbecause\zis not supported by cuDf. Alternatively, we could transpile$\zto$(?![\r\n\u0085\u2028\u2029]). However, cuDf doesn't support negative look ahead.