Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spark UT fix for Parquet decimal #11498

Draft
wants to merge 3 commits into
base: branch-24.12
Choose a base branch
from

Conversation

mattahrens
Copy link
Collaborator

Closes #11433
Contributes to #11403

Signed-off-by: mattahrens <matthewahrens@gmail.com>
Signed-off-by: mattahrens <matthewahrens@gmail.com>
@mattahrens mattahrens self-assigned this Sep 25, 2024
@mattahrens
Copy link
Collaborator Author

build

@mattahrens mattahrens changed the title [BUG] Spark UT fix for Parquet decimal Spark UT fix for Parquet decimal Sep 25, 2024
revans2
revans2 previously approved these changes Sep 25, 2024
Copy link
Collaborator

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Could you file a follow on issue to clean up this file now that we no longer support spark 3.1?

@mattahrens mattahrens marked this pull request as ready for review September 25, 2024 14:31
@mattahrens mattahrens marked this pull request as draft September 25, 2024 16:36
@mattahrens
Copy link
Collaborator Author

Moving to draft as initial repro is fixed, but then subsequent parts of the UT is showing a failure, so it needs further investigation.

@mattahrens mattahrens changed the base branch from branch-24.10 to branch-24.12 October 9, 2024 14:07
@mattahrens mattahrens dismissed revans2’s stale review October 9, 2024 14:07

The base branch was changed.

@sameerz sameerz added the test Only impacts tests label Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Only impacts tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Spark UT framework: SPARK-34212 Parquet should read decimals correctly
3 participants