Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci[maxtext]: adds rosetta directory to maxtext containers #1097

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci[maxtext]: adds rosetta directory to maxtext containers #1097

wants to merge 1 commit into from

Conversation

terrykong
Copy link
Contributor

  • makes xla flag env files available to users

@terrykong
ci[maxtext]: adds rosetta directory to maxtext containers
84665f5 
- makes xla flag env files available to users

Signed-off-by: Terry Kong <terryk@nvidia.com>
@DwarKapex
Copy link
Contributor

@terrykong You copy the whole rosetta folder. Is it intentional?

@terrykong
Copy link
Contributor Author

@DwarKapex It was intentional. I did a check and that dir is 2.2M. Would you rather I just copy in the maxtext directory?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DwarKapex DwarKapex DwarKapex approved these changes

@kocchop kocchop Awaiting requested review from kocchop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@terrykong @DwarKapex