-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Air leakage type "unit total" #1257
Conversation
Next steps here are, in order:
|
Questions from meeting:
|
Meeting notes:
|
|
Sorry, this PR caught my attention and I have a couple naive questions.
|
Plan is to:
|
@ekpresent Here are before (i.e., base) and after (i.e., feature) average % Error results for 10K datapoints. Across the whole set:
Segmented by:
|
These enduses are going up for some reason. Might be worth finding out why.
|
For example, ID=21. Modeled ACH50 for this MF unit changes from 8.09 to 0.59. HeatingCapacity (furnace) changes from 6188 to 1860. CoolingCapacity (mini-split air conditioner) changes from 8097 to 6066. Indeed cooling increases slightly. We'll need to look into this. @shorowit do you have any insight here? |
This could be due to a high amount of internal gains -- infiltration was previously aiding the cooling. Should check number of occupants, plug load multiplier. |
ID=21 is:
|
Tony to update description and add a description in the assumptions about how we are modeling infiltration for multi-family units. Description: Total infiltration to the dwelling unit adjusted by ratio of exterior envelope surface area to total envelope surface area |
Pull Request Description
This PR fixed a bug that resulted in the modeled ACH50 infiltration values of the units being larger than the sampled ACH50 for the building. The update is to change options_lookup and ResStockArguments to use unit total air leakage type instead of the current unit exterior only type w/ infiltration adjustment approach. This change provides the infiltration value sampled as the total infiltration from the exterior and other neighboring units. The infiltration to the exterior is then calculated as a percentage of the exterior surfaces. This change will reduce the modeled infiltration for MF units. The modeled infiltration to the exterior (
build_existing_model.air_leakage_to_outside_ach_50
) is now reported in the results.Updates
Remove the "Infiltration adjustment for SFA/MF units" block of code from ResStockArguments.
Update BuildExistingModel to register adjusted total infiltration ACH50 value.
Some related plots in: #728
Some clarification (need documentation update):
data/dictionary/inputs.csv
with anbuild_existing_model.air_leakage_to_outside_ach_50
entry along with a description: "Total infiltration to the dwelling unit adjusted by ratio of exterior envelope surface area to total envelope surface area."Checklist
Not all may apply:
Tests (and test files) have been updatedIf related to resstock-estimation, checklist includes data dictionary, source report, options saturation, options_lookup.openstudio tasks.rb update_measures
has been run