Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heating and Cooling Unavailable Days #1254

Merged
merged 77 commits into from
Sep 27, 2024
Merged

Heating and Cooling Unavailable Days #1254

merged 77 commits into from
Sep 27, 2024

Conversation

joseph-robertson
Copy link
Contributor

@joseph-robertson joseph-robertson commented Jun 6, 2024

Pull Request Description

Companion PR: https://github.com/NREL/resstock-estimation/pull/416

The purpose of this PR is to account for dwelling units whose HVAC system (heating/cooling) is unavailable for some number of days during the year (per RECS 2020).

Specifically, this PR:

  • Adds new Heating Unavailable Days.tsv and Cooling Unavailable Days.tsv housing characteristics files
  • Adds new arguments to ResStockArguments:
    • schedules_space_heating_unavailable_days (integer; assigned by Heating Unavailable Days)
    • schedules_space_cooling_unavailable_days (integer; assigned by Cooling Unavailable Days)
    • building_id
      • this becomes the seed for a random number generator (similar to how BuildResidentialScheduleFile uses it)
      • both BuildExistingModel and ApplyUpgrade assign building_id to ResStockArguments
  • Updates ResStockArguments to determine unavailable period dates when sampled options are 1+ unavailable days:
    • Year Round
      • set the unavailable period to "Jan 1 - Dec 31"
    • Partial Year (e.g., 1, 7, 14 days)
      • get the Building America heating/cooling months per weather data and BAHSP definition
      • randomly select (deterministically) n-day period start/end dates beginning in the BA heating/cooling months (if no BA heating/cooling months, e.g., Hawaii, assume heating/cooling months are Dec-Feb/Jun-Aug)
      • set unavailable period arguments based on randomly selected n-day period start/end dates
      • if the number of unavailable days is longer than the season Building America season, the unavailable period will just extend beyond the BA season

This PR also updates BuildExistingModel to register the randomly selected unavailable periods:

  • build_existing_model.heating_unavailable_period
  • build_existing_model.cooling_unavailable_period

CI results:
image

Checklist

Not all may apply:

@joseph-robertson joseph-robertson self-assigned this Jun 6, 2024
@joseph-robertson joseph-robertson changed the base branch from develop to res-reporting June 13, 2024 21:38
@joseph-robertson joseph-robertson changed the base branch from develop to latest-os-hpxml September 18, 2024 04:32
Base automatically changed from latest-os-hpxml to develop September 26, 2024 19:43
@afontani afontani merged commit bb47cf3 into develop Sep 27, 2024
@afontani afontani deleted the hvac-seasons branch September 27, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants