Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Duct Location and Duct Leakage to Outside, try 2 #1112

Merged
merged 38 commits into from
Aug 9, 2023
Merged

add Duct Location and Duct Leakage to Outside, try 2 #1112

merged 38 commits into from
Aug 9, 2023

Conversation

joseph-robertson
Copy link
Contributor

@joseph-robertson joseph-robertson commented Jul 31, 2023 •
edited
Loading

Pull Request Description

Checklist:

  • Copy national baseline yml file and bump n_datapoints to 10K (we want to see if there are any failures)
  • Locally check that, e.g., room AC with no heating, and has ducts, doesn't produce an error (we want to understand whether a graceful error is thrown for this situation)

Checklist

Not all may apply:

  • Tests (and test files) have been updated
  • Documentation has been updated
    • If related to resstock-estimation, checklist includes data dictionary, source report, options_lookup
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected regression test changes on CI (checked comparison artifacts)

@joseph-robertson
Merge commit '638ffcce9de8642c1ab0a9dfb7e49b6736e6da20' into ll/duct_…
cd7fe6e 
…location2
@joseph-robertson
Squashed 'resources/hpxml-measures/' changes from b6fc15547a72..8622c…
638ffcc 
…16013ae

8622c16013ae Update comments/changelog [ci skip]
77bbfa880a77 BuildResidentialHPXML measure: Allow duct area fractions (as an alternative to duct areas in ft^2).
94d3b0b9697b Update README.md [ci skip]

git-subtree-dir: resources/hpxml-measures
git-subtree-split: 8622c16013ae5469e05607a951e60f0869267945
@joseph-robertson
Revert changes to resstock arguments measure.
5df40b3
@joseph-robertson
Revert change to expected run_analysis warning.
4ed1ebe
@joseph-robertson
Update lookup for new area_fraction arguments.
4f9b95a
@joseph-robertson
Remove the expected ducts warning.
254fd90
@joseph-robertson
Bad speeling in lookup.
d438e02
@joseph-robertson
Merge commit '10dfb788fd8eef7e7edcfff5bd6ec34fee19c416' into ll/duct_…
6d6274c 
…location2
@joseph-robertson
Squashed 'resources/hpxml-measures/' changes from 8622c16013ae..efd77…
10dfb78 
…4aaca88

efd774aaca88 Clarify docs.
67e71f32f545 Prevent possible divide by zero error if duct area is zero (e.g., because the number of return registers are zero).

git-subtree-dir: resources/hpxml-measures
git-subtree-split: efd774aaca88cdf7b80ab3aaf62a8a6a0d55b8a9
@joseph-robertson joseph-robertson mentioned this pull request Aug 1, 2023
Merged
7 tasks
@joseph-robertson joseph-robertson added this to the ResStock v3.2.0 milestone Aug 1, 2023
joseph-robertson and others added 10 commits August 8, 2023 07:30
@joseph-robertson
Merge branch 'll/duct_location' into ll/duct_location2
3056cb5
@joseph-robertson
Merge branch 'll/duct_location2' of github.com:NREL/resstock into ll/…
03f09d8 
…duct_location2
Latest results.
39d4bb0
@joseph-robertson
Merge branch 'll/duct_location' into ll/duct_location2
0088aaa
@joseph-robertson
Squashed 'resources/hpxml-measures/' changes from efd774aaca88..704f0…
57008ba 
…d1488aa

704f0d1488aa Merge pull request #1455 from NREL/buildreshpxml_duct_fractions

git-subtree-dir: resources/hpxml-measures
git-subtree-split: 704f0d1488aa0770b46b159a6a1904917520821b
@joseph-robertson
Merge commit '57008baba4b933c97a309148648d6f82125d2077' into ll/duct_…
8dd2bc7 
…location2
@joseph-robertson
Revert temporary changes used for testing.
ddb8006
@lixiliu
Merge branch 'll/duct_location' into ll/duct_location2
8390438
Latest results.
138c610
@joseph-robertson
Merge branch 'll/duct_location' into ll/duct_location2
286ced5
@joseph-robertson joseph-robertson self-assigned this Aug 9, 2023
@joseph-robertson joseph-robertson marked this pull request as ready for review August 9, 2023 15:13
@joseph-robertson joseph-robertson merged commit d5bfd70 into ll/duct_location Aug 9, 2023
1 of 4 checks passed
@joseph-robertson joseph-robertson deleted the ll/duct_location2 branch August 9, 2023 15:13
@lixiliu lixiliu mentioned this pull request Aug 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joseph-robertson joseph-robertson

Labels
None yet
Projects
None yet
Milestone
ResStock v3.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@joseph-robertson @lixiliu