Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Expose stencil vertical domain to Frozen Stencil #78

Conversation

FlorianDeconinck
Copy link
Collaborator

@FlorianDeconinck FlorianDeconinck commented Oct 7, 2024

Description
The new feature in development to allow absolute indexing in K allows to easily code patterns like "get the top of the column"... as long as you know what top is.

As we have done in the past for I and J, we expose via __externals__ the bounds of K for the stencil.

This is a zero-cost variable (no cost when not used, no perf cost when used)

How Has This Been Tested?
Extended utest

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

twicki
twicki previously approved these changes Oct 7, 2024
Copy link
Collaborator

@twicki twicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@bensonr bensonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks good.

@fmalatino fmalatino merged commit b5a7fa7 into NOAA-GFDL:develop Oct 7, 2024
5 checks passed
@FlorianDeconinck FlorianDeconinck deleted the feature/K_axis_bounds_in_externals branch October 8, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants