Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to merge blocks in serialized data #68

Merged

Conversation

oelbert
Copy link
Collaborator

@oelbert oelbert commented Aug 30, 2024

Description
This PR adds an option to merge data into a single savepoint when the Fortran code has been horizontally blocked. Data is reshaped into nx by ny in order to fit directly into the correct quantity size.

How Has This Been Tested?
This code has been used to postprocess test data for pySHiELD development

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

fmalatino
fmalatino previously approved these changes Aug 30, 2024
Copy link
Collaborator

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Remove changed to gt4py and dace
  • Run Lint

ndsl/stencils/testing/serialbox_to_netcdf.py Outdated Show resolved Hide resolved
ndsl/stencils/testing/serialbox_to_netcdf.py Show resolved Hide resolved
Copy link
Contributor

@fmalatino fmalatino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the way

epic music plays

@FlorianDeconinck FlorianDeconinck merged commit 82e5384 into NOAA-GFDL:develop Sep 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants